Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Backport changes from the Revamped fork #270

Open
Patrxgt opened this issue Feb 10, 2025 · 8 comments
Open

[Enhancement] Backport changes from the Revamped fork #270

Patrxgt opened this issue Feb 10, 2025 · 8 comments

Comments

@Patrxgt
Copy link

Patrxgt commented Feb 10, 2025

It would be nice to have all of the improvements from the Revamped fork made by @xHybred in the original version of NVIDIA Profile Inspector.

@Patrxgt Patrxgt changed the title [Enhancement] Backport the changes from the Revamped fork [Enhancement] Backport changes from the Revamped fork Feb 10, 2025
@Squall-Leonhart
Copy link

no, it wouldn't.

not the forced requirement for versions of dot net that aren't preincluded anyway.,

@Patrxgt
Copy link
Author

Patrxgt commented Feb 15, 2025

Yes, it would.

Installing .NET runtime isn't an issue for most of the people, so your argument is flawed.

@Squall-Leonhart
Copy link

Yes, it would.

Installing .NET runtime isn't an issue for most of the people, so your argument is flawed.

No, sorry, off you go.

@Patrxgt
Copy link
Author

Patrxgt commented Feb 18, 2025

No, thanks. I'm staying.

@Orbmu2k
Copy link
Owner

Orbmu2k commented Feb 18, 2025

its totally fine when there are forks

i dont like dotnet core runtime with exact version match requirement either.

with old .net framework you always just needed the latest version and you were fine with all apps build on lower versions. also .net framework is still preincluded in windows.

the new ahead of time compilation binary output with self contained dotnet is bloating and does not work for windows forms yet. so you need windows app sdk libs anyway. or rely on having the correct runtime version already installed.

lets keep it small and simple, there are no real benefits switching to new dotnet core at least for this project

@achtchaern
Copy link

Thank you for deciding to stay with the old .NET! I'm one of those who doesn't want to install these new frameworks :)

@Squall-Leonhart
Copy link

i dont like dotnet core runtime with exact version match requirement either.

Major rollforward is a thing, now that theres a guarantee the new abi will support the previous, but the link microsoft uses on net core apps to get the required version often breaks and doesn't get thrown anyway if you have say 9.0.2 but the app needs 9.0.4, it will usually silent fail instead.

@xHybred
Copy link

xHybred commented Feb 25, 2025

As the author of Revamped, I support this decision, but I also appreciate someone making a request on it!

Hopefully/maybe though some of the improvements can be brought over to the the original NVPI without the new dotnet core dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants