Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile workflow should run at least one of the SpecFlow tests #8819

Closed
BenedekFarkas opened this issue Dec 7, 2024 · 0 comments · Fixed by #8820
Closed

Compile workflow should run at least one of the SpecFlow tests #8819

BenedekFarkas opened this issue Dec 7, 2024 · 0 comments · Fixed by #8820
Assignees
@BenedekFarkas
Labels
Tests
Milestone
Orchard 1.10.4

Comments

@BenedekFarkas
Copy link
Member

A funny coincidence of recent PRs is that upgrading Newtonsoft.Json on 1.10.x and NHibernate on dev were both breaking changes regarding the web.config of the SpecFlow hosting app, because I forgot update the assembly binding redirects.

We run all the SpecFlow tests on both branches once a day, but let's run at least one of the SpecFlow tests during the Compile workflow too, so we can reduce the chance of a PR breaking the SpecFlow hosting app a bit.
@BenedekFarkas BenedekFarkas added this to the Orchard 1.10.4 milestone Dec 7, 2024
@BenedekFarkas BenedekFarkas self-assigned this Dec 7, 2024
@BenedekFarkas BenedekFarkas changed the title Compile should run at least one of the SpecFlow tests Compile workflow should run at least one of the SpecFlow tests Dec 7, 2024
@BenedekFarkas BenedekFarkas mentioned this issue Dec 7, 2024
Merged
@BenedekFarkas BenedekFarkas linked a pull request Dec 7, 2024 that will close this issue
#8819: Compile workflow should run at least one of the SpecFlow tests #8820
Merged
BenedekFarkas added a commit that referenced this issue Dec 7, 2024
@BenedekFarkas
#8819: Compile workflow should run at least one of the SpecFlow tests (…
c3b98ba 
…#8820)

* Using Title Casing in the Compile workflow's step names

* Adding step to run the Setup with SpecFlow

* Fixing typo

* Fixing that upgrading Newtonsoft.Json to 13.x broke the SpecFlow test execution app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenedekFarkas BenedekFarkas

Labels
Tests
Projects
None yet
Milestone
Orchard 1.10.4
Development

Successfully merging a pull request may close this issue.

#8819: Compile workflow should run at least one of the SpecFlow tests OrchardCMS/Orchard
1 participant
@BenedekFarkas