Skip to content

Commit 1b90078

Browse files
committed
Make extensions as static readonly fields
1 parent 5b2b7e8 commit 1b90078

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

src/OrchardCoreContrib.PoExtractor.DotNet.CS/CSharpProjectProcessor.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ namespace OrchardCoreContrib.PoExtractor.DotNet.CS
1212
/// </summary>
1313
public class CSharpProjectProcessor : IProjectProcessor
1414
{
15+
private static readonly string _cSharpExtension = "*.cs";
16+
1517
/// <inheritdoc/>
1618
public virtual void Process(string path, string basePath, LocalizableStringCollection localizableStrings)
1719
{
@@ -42,7 +44,7 @@ public virtual void Process(string path, string basePath, LocalizableStringColle
4244
new DisplayAttributeShortNameStringExtractor(csharpMetadataProvider)
4345
}, localizableStrings);
4446

45-
foreach (var file in Directory.EnumerateFiles(path, "*.cs", SearchOption.AllDirectories).OrderBy(file => file))
47+
foreach (var file in Directory.EnumerateFiles(path, $"*{_cSharpExtension}", SearchOption.AllDirectories).OrderBy(file => file))
4648
{
4749
if (file.StartsWith(Path.Combine(path, "obj")))
4850
{

src/OrchardCoreContrib.PoExtractor.DotNet.VB/VisualBasicProjectProcessor.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ namespace OrchardCoreContrib.PoExtractor.DotNet.VB
1212
/// </summary>
1313
public class VisualBasicProjectProcessor : IProjectProcessor
1414
{
15+
private static readonly string _visualBasicExtension = "*.vb";
16+
1517
/// <inheritdoc/>
1618
public void Process(string path, string basePath, LocalizableStringCollection localizableStrings)
1719
{
@@ -42,7 +44,7 @@ public void Process(string path, string basePath, LocalizableStringCollection lo
4244
new DisplayAttributeShortNameStringExtractor(visualBasicMetadataProvider)
4345
}, localizableStrings);
4446

45-
foreach (var file in Directory.EnumerateFiles(path, "*.vb", SearchOption.AllDirectories).OrderBy(file => file))
47+
foreach (var file in Directory.EnumerateFiles(path, $"*{_visualBasicExtension}", SearchOption.AllDirectories).OrderBy(file => file))
4648
{
4749
using (var stream = File.OpenRead(file))
4850
{

src/OrchardCoreContrib.PoExtractor.Liquid/LiquidProjectProcessor.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ namespace OrchardCoreContrib.PoExtractor.Liquid
1414
/// </summary>
1515
public class LiquidProjectProcessor : IProjectProcessor
1616
{
17+
private static readonly string _liquidExtension = "*.liquid";
18+
1719
private readonly LiquidViewParser _parser;
1820

1921
/// <summary>
@@ -47,7 +49,7 @@ public void Process(string path, string basePath, LocalizableStringCollection lo
4749
var liquidMetadataProvider = new LiquidMetadataProvider(basePath);
4850
var liquidVisitor = new ExtractingLiquidWalker(new[] { new LiquidStringExtractor(liquidMetadataProvider) }, localizableStrings);
4951

50-
foreach (var file in Directory.EnumerateFiles(path, "*.liquid", SearchOption.AllDirectories).OrderBy(file => file))
52+
foreach (var file in Directory.EnumerateFiles(path, $"*{_liquidExtension}", SearchOption.AllDirectories).OrderBy(file => file))
5153
{
5254
using (var stream = File.OpenRead(file))
5355
{

src/OrchardCoreContrib.PoExtractor.Razor/MetadataProviders/RazorMetadataProvider.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ namespace OrchardCoreContrib.PoExtractor.Razor.MetadataProviders
1212
/// </summary>
1313
public class RazorMetadataProvider : IMetadataProvider<SyntaxNode>
1414
{
15+
private static readonly string _razorExtension = ".cshtml";
16+
1517
private string[] _sourceCache;
1618
private string _sourceCachePath;
1719

@@ -36,7 +38,7 @@ public string GetContext(SyntaxNode node)
3638

3739
var path = node.SyntaxTree.FilePath.TrimStart(_basePath);
3840

39-
return path.Replace(Path.DirectorySeparatorChar, '.').Replace(".cshtml", string.Empty);
41+
return path.Replace(Path.DirectorySeparatorChar, '.').Replace(_razorExtension, string.Empty);
4042
}
4143

4244
/// <inheritdoc/>

0 commit comments

Comments
 (0)