adj: removed test block

Author: Tools-cx-app

okrmng/src/cli.rs

@@ -102,43 +102,3 @@ fn sync_directory(path: &Path) -> Result<()> {
 fn sync_directory(_path: &Path) -> Result<()> {
     Ok(())
 }
-
-#[cfg(test)]
-mod tests {
-    use super::{App, Config};
-    use std::collections::BTreeSet;
-
-    use tempfile::tempdir;
-
-    #[test]
-    fn missing_config_loads_as_default() {
-        let dir = tempdir().unwrap();
-        let path = dir.path().join("config.toml");
-
-        let config = Config::load_from_path(&path).unwrap();
-
-        assert_eq!(config, Config::default());
-    }
-
-    #[test]
-    fn save_and_reload_round_trips_sorted_config() {
-        let dir = tempdir().unwrap();
-        let path = dir.path().join("config.toml");
-        let config = Config {
-            app: App {
-                system_app: BTreeSet::from([
-                    "com.example.beta".to_string(),
-                    "com.example.alpha".to_string(),
-                ]),
-                priv_app: BTreeSet::from(["com.example.gamma".to_string()]),
-            },
-        };
-
-        config.save_to_path(&path).unwrap();
-        let reloaded = Config::load_from_path(&path).unwrap();
-        let contents = std::fs::read_to_string(&path).unwrap();
-
-        assert_eq!(reloaded, config);
-        assert!(contents.contains("system_app = [\"com.example.alpha\", \"com.example.beta\"]"));
-    }
-}

okrmng/src/config.rs

@@ -8,7 +8,9 @@ pub fn has_known_user_app_prefix(path: &Path) -> bool {
         || is_adopted_storage_app_path(&normalized)
 }
 
-#[cfg_attr(test, allow(dead_code))]
+fn is_known_existing_user_app_path(path: &Path) -> bool {
+    has_known_user_app_prefix(path) || { false }
+}
 pub fn normalize_user_app_code_path(path: &Path) -> Option<PathBuf> {
     if path.is_dir() && is_known_existing_user_app_path(path) {
         return Some(path.to_path_buf());
@@ -30,20 +32,6 @@ pub fn normalize_user_app_code_path(path: &Path) -> Option<PathBuf> {
 
     None
 }
-
-fn is_known_existing_user_app_path(path: &Path) -> bool {
-    has_known_user_app_prefix(path) || {
-        #[cfg(test)]
-        {
-            has_embedded_test_user_app_prefix(path)
-        }
-        #[cfg(not(test))]
-        {
-            false
-        }
-    }
-}
-
 fn is_adopted_storage_app_path(normalized: &str) -> bool {
     let Some(rest) = normalized.strip_prefix("/mnt/expand/") else {
         return false;
@@ -55,42 +43,3 @@ fn is_adopted_storage_app_path(normalized: &str) -> bool {
         (Some(uuid), Some("app")) if !uuid.is_empty()
     )
 }
-
-#[cfg(test)]
-fn has_embedded_test_user_app_prefix(path: &Path) -> bool {
-    let normalized = path.to_string_lossy().replace('\\', "/");
-    normalized.contains("/data/app/") || normalized.contains("/data/app-private/")
-}
-
-#[cfg(test)]
-mod tests {
-    use std::path::Path;
-
-    use super::has_known_user_app_prefix;
-
-    #[test]
-    fn known_user_app_prefix_covers_android_install_locations() {
-        assert!(has_known_user_app_prefix(Path::new(
-            "/data/app/~~token/com.example/base.apk"
-        )));
-        assert!(has_known_user_app_prefix(Path::new(
-            "/data/app-private/com.example.locked/base.apk"
-        )));
-        assert!(has_known_user_app_prefix(Path::new(
-            "/mnt/expand/uuid/app/com.example/base.apk"
-        )));
-    }
-
-    #[test]
-    fn known_user_app_prefix_rejects_non_app_roots() {
-        assert!(!has_known_user_app_prefix(Path::new(
-            "/system/app/Example/Example.apk"
-        )));
-        assert!(!has_known_user_app_prefix(Path::new(
-            "/mnt/expand/uuid/media/com.example/base.apk"
-        )));
-        assert!(!has_known_user_app_prefix(Path::new(
-            "/data/user/0/com.example/files"
-        )));
-    }
-}

oukaro/src/android_install_path.rs

@@ -36,24 +36,3 @@ pub fn validate_package_name(package: &str) -> Result<()> {
 
     Ok(())
 }
-
-#[cfg(test)]
-mod tests {
-    use super::{is_valid_package_name, validate_package_name};
-
-    #[test]
-    fn android_package_rules_accept_standard_application_ids() {
-        assert!(is_valid_package_name("com.example.app"));
-        assert!(is_valid_package_name("com.Example_1.app_2"));
-    }
-
-    #[test]
-    fn android_package_rules_reject_invalid_names() {
-        assert!(validate_package_name("").is_err());
-        assert!(validate_package_name("single").is_err());
-        assert!(validate_package_name("com..example").is_err());
-        assert!(validate_package_name("1com.example").is_err());
-        assert!(validate_package_name("com.example-app").is_err());
-        assert!(validate_package_name("com.example/app").is_err());
-    }
-}

oukaro/src/android_package.rs

@@ -18,27 +18,3 @@ impl SystemUserPackageState {
         self.installed && !self.hidden
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::SystemUserPackageState;
-
-    #[test]
-    fn package_state_matches_android_is_available_semantics() {
-        assert!(SystemUserPackageState::default().is_available());
-        assert!(
-            !SystemUserPackageState {
-                installed: false,
-                hidden: false,
-            }
-            .is_available()
-        );
-        assert!(
-            !SystemUserPackageState {
-                installed: true,
-                hidden: true,
-            }
-            .is_available()
-        );
-    }
-}

oukaro/src/android_package_state.rs

@@ -463,195 +463,3 @@ fn bytes_to_base64(bytes: &[u8]) -> String {
 
     out
 }
-
-#[cfg(test)]
-mod tests {
-    use super::{decode_xmlish_bytes, parse_boolish, parse_i64ish};
-
-    fn push_utf(buf: &mut Vec<u8>, value: &str) {
-        let len = u16::try_from(value.len()).unwrap();
-        buf.extend_from_slice(&len.to_be_bytes());
-        buf.extend_from_slice(value.as_bytes());
-    }
-
-    fn push_utf_bytes(buf: &mut Vec<u8>, value: &[u8]) {
-        let len = u16::try_from(value.len()).unwrap();
-        buf.extend_from_slice(&len.to_be_bytes());
-        buf.extend_from_slice(value);
-    }
-
-    fn push_new_interned(buf: &mut Vec<u8>, value: &str) {
-        buf.extend_from_slice(&0xFFFF_u16.to_be_bytes());
-        push_utf(buf, value);
-    }
-
-    fn push_interned_ref(buf: &mut Vec<u8>, index: u16) {
-        buf.extend_from_slice(&index.to_be_bytes());
-    }
-
-    #[test]
-    fn parse_boolish_handles_common_android_representations() {
-        assert_eq!(parse_boolish("true"), Some(true));
-        assert_eq!(parse_boolish("False"), Some(false));
-        assert_eq!(parse_boolish("1"), Some(true));
-        assert_eq!(parse_boolish("0"), Some(false));
-        assert_eq!(parse_boolish("maybe"), None);
-    }
-
-    #[test]
-    fn parse_i64ish_understands_decimal_and_hex() {
-        assert_eq!(parse_i64ish("16"), Some(16));
-        assert_eq!(parse_i64ish("0x10"), Some(16));
-        assert_eq!(parse_i64ish("ff"), Some(255));
-        assert_eq!(parse_i64ish("-0x10"), Some(-16));
-    }
-
-    #[test]
-    fn android_binary_xml_is_decoded_to_text_xml() {
-        let mut abx = Vec::new();
-        abx.extend_from_slice(b"ABX\0");
-        abx.push(0x00);
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "packages");
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "package");
-
-        abx.push(0x2F);
-        push_new_interned(&mut abx, "name");
-        push_utf(&mut abx, "com.example.app");
-
-        abx.push(0x2F);
-        push_new_interned(&mut abx, "codePath");
-        push_utf(&mut abx, "/data/app/~~abc/com.example.app/base.apk");
-
-        abx.push(0x7F);
-        push_new_interned(&mut abx, "publicFlags");
-        abx.extend_from_slice(&(0x10_i32).to_be_bytes());
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 1);
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 0);
-
-        abx.push(0x01);
-
-        let decoded = decode_xmlish_bytes(&abx).unwrap();
-
-        assert!(decoded.contains("<package"));
-        assert!(decoded.contains(r#"name="com.example.app""#));
-        assert!(decoded.contains(r#"codePath="/data/app/~~abc/com.example.app/base.apk""#));
-        assert!(decoded.contains(r#"publicFlags="0x10""#));
-    }
-
-    #[test]
-    fn android_binary_xml_decodes_boolean_attributes() {
-        let mut abx = Vec::new();
-        abx.extend_from_slice(b"ABX\0");
-        abx.push(0x00);
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "package-restrictions");
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "pkg");
-
-        abx.push(0x2F);
-        push_new_interned(&mut abx, "name");
-        push_utf(&mut abx, "com.example.alpha");
-
-        abx.push(0xDF);
-        push_new_interned(&mut abx, "inst");
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 1);
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 0);
-
-        abx.push(0x01);
-
-        let decoded = decode_xmlish_bytes(&abx).unwrap();
-
-        assert!(decoded.contains(r#"<pkg name="com.example.alpha" inst="false">"#));
-    }
-
-    #[test]
-    fn text_xml_utf16le_without_bom_is_detected() {
-        let bytes = b"<root>ok</root>"
-            .iter()
-            .flat_map(|byte| [*byte, 0x00])
-            .collect::<Vec<_>>();
-
-        let decoded = decode_xmlish_bytes(&bytes).unwrap();
-
-        assert_eq!(decoded, "<root>ok</root>");
-    }
-
-    #[test]
-    fn android_binary_xml_supports_art_modified_utf_with_four_byte_sequences() {
-        let mut abx = Vec::new();
-        abx.extend_from_slice(b"ABX\0");
-        abx.push(0x00);
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "emoji");
-
-        abx.push(0x24);
-        push_utf_bytes(&mut abx, "😀".as_bytes());
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 0);
-        abx.push(0x01);
-
-        let decoded = decode_xmlish_bytes(&abx).unwrap();
-
-        assert_eq!(decoded, "<emoji>😀</emoji>");
-    }
-
-    #[test]
-    fn android_binary_xml_resolves_entity_refs_like_android() {
-        let mut abx = Vec::new();
-        abx.extend_from_slice(b"ABX\0");
-        abx.push(0x00);
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "root");
-
-        abx.push(0x26);
-        push_utf(&mut abx, "amp");
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 0);
-        abx.push(0x01);
-
-        let decoded = decode_xmlish_bytes(&abx).unwrap();
-
-        assert_eq!(decoded, "<root>&amp;</root>");
-    }
-
-    #[test]
-    fn android_binary_xml_base64_attributes_are_rendered_as_base64_text() {
-        let mut abx = Vec::new();
-        abx.extend_from_slice(b"ABX\0");
-        abx.push(0x00);
-
-        abx.push(0x02);
-        push_new_interned(&mut abx, "root");
-
-        abx.push(0x5F);
-        push_new_interned(&mut abx, "blob");
-        abx.extend_from_slice(&(3_u16).to_be_bytes());
-        abx.extend_from_slice(&[0x01, 0x02, 0x03]);
-
-        abx.push(0x03);
-        push_interned_ref(&mut abx, 0);
-        abx.push(0x01);
-
-        let decoded = decode_xmlish_bytes(&abx).unwrap();
-
-        assert_eq!(decoded, r#"<root blob="AQID"></root>"#);
-    }
-}

oukaro/src/android_xml.rs

@@ -100,20 +100,3 @@ fn sync_directory(path: &Path) -> Result<()> {
 fn sync_directory(_path: &Path) -> Result<()> {
     Ok(())
 }
-
-#[cfg(test)]
-mod tests {
-    use tempfile::tempdir;
-
-    use super::write_atomically;
-
-    #[test]
-    fn atomic_writer_creates_complete_config_file() {
-        let dir = tempdir().unwrap();
-        let path = dir.path().join("config.toml");
-
-        write_atomically(&path, b"[app]\n").unwrap();
-
-        assert_eq!(std::fs::read_to_string(path).unwrap(), "[app]\n");
-    }
-}