Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a distinct API module for all request-based functionality #137

Open
Zeitsperre opened this issue Jun 30, 2023 · 0 comments
Open

Make a distinct API module for all request-based functionality #137

Zeitsperre opened this issue Jun 30, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Zeitsperre
Copy link
Collaborator

Summary

Miranda's API request modules should be collected into one submodule, e.g. miranda.fetch or miranda.remote, with accompanying submodules based on the source in which they are targeting (eccc, ecmwf, esgf, etc.).

Justification

Many of the libraries that are leveraged to perform these actions use specific configurations for things such as:

  • Fetching credentials (.rc files in the ~/ drive or fed directly to the API request class instance)
  • Naming files
  • Asynchronous download support (built-in or only available via import multiprocessing)

These helper libraries are completely optional as of Miranda v0.5.0, and are only installed if explicitly requested. Since this is not the major focus of Miranda and other libraries might be more appropriate for the job in the future, it would be good to move these to a separate module that is not loaded when running import miranda (from miranda import fetch).

@Zeitsperre Zeitsperre added the enhancement New feature or request label Jun 30, 2023
@Zeitsperre Zeitsperre self-assigned this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant