Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to create the mask in extract_dataset #183

Open
1 task
juliettelavoie opened this issue Apr 4, 2023 · 1 comment
Open
1 task

Add the possibility to create the mask in extract_dataset #183

juliettelavoie opened this issue Apr 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@juliettelavoie
Copy link
Contributor

Addressing a Problem?

Now, the mask argument takes an already formed mask.

I could be useful to have a way to create the mask and apply it.

Potential Solution

If mask is a dict, pass it as argument to the xs.create_mask to create the mask and then apply it to the data.

ex. mask_args = {
"variable": "sftlf",
"where_operator": ">=",
"where_threshold": 95,
"mask_nans": True,
}

The call to xs.create_mask needs the data. It could be extracted from the catalog similarly to how the mask is extracted now.

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.
@juliettelavoie juliettelavoie added the enhancement New feature or request label Apr 4, 2023
@juliettelavoie
Copy link
Contributor Author

Creep_fill could also be added to create_mask to allow for the creation of more complex masks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant