Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xs.climatological_mean and compute_deltas are broken with daily data #186

Open
1 task
RondeauG opened this issue Apr 13, 2023 · 0 comments
Open
1 task
Labels
bug Something isn't working

Comments

@RondeauG
Copy link
Collaborator

RondeauG commented Apr 13, 2023

Setup Information

  • xscen version: 0.5.14b

Description

xs.climatological_mean and xs.compue_deltas unstack data into [year, month, day] to perform their actions, then puts everything back into a 1D time array using:
ds = ds.stack(time=("year", "month", "day")) (line 123 in climatological_mean)

This might have been an oversight on our part, but this only works when all values of day exist for every month. With daily data, this creates an array of size 372 (31 x 12), including many impossible days that make pandas crash.

Steps To Reproduce

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to address this bug.
@RondeauG RondeauG added the bug Something isn't working label Apr 13, 2023
@RondeauG RondeauG changed the title xs.climatological_mean is broken with daily data xs.climatological_mean and compute_deltas are broken with daily data Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant