Skip to content

Commit 0678e02

Browse files
committed
fix: tests and datetime copying
1 parent ba1e003 commit 0678e02

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

Diff for: tests/test_conversions.py

+12-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import csv
22
from datetime import datetime
3+
from time import sleep
34
from unittest import TestCase, main
45

56
from trd_cli.conversions import convert_generic, extract_participant_info, QUESTIONNAIRES
@@ -13,7 +14,7 @@ def test_convert_generic(self):
1314
expectations = {
1415
"phq9": {
1516
"phq9_response_id": "1589930675",
16-
"phq9_datetime": "2024-11-04 12:59:24.9477348+00:00",
17+
"phq9_datetime": "2024-11-04T12:59:24.9477348+00:00",
1718
"phq9_1_interest_float": "3.0",
1819
"phq9_2_depression_float": "3.0",
1920
"phq9_3_sleep_float": "3.0",
@@ -35,7 +36,7 @@ def test_convert_generic(self):
3536
"gad7_6_irritable_float": "2.0",
3637
"gad7_7_afraid_float": "3.0",
3738
"gad7_8_difficult_float": "0.0",
38-
"gad7_datetime": "2024-11-05 12:05:43.5629631+00:00",
39+
"gad7_datetime": "2024-11-05T12:05:43.5629631+00:00",
3940
"gad7_score_total_float": "12.0",
4041
},
4142
"mania": {
@@ -45,12 +46,12 @@ def test_convert_generic(self):
4546
"mania_3_sleep_float": "1.0",
4647
"mania_4_talking_float": "1.0",
4748
"mania_5_activity_float": "2.0",
48-
"mania_datetime": "2024-11-05 12:05:59.3055890+00:00",
49+
"mania_datetime": "2024-11-05T12:05:59.3055890+00:00",
4950
"mania_score_total_float": "6.0",
5051
},
5152
"reqol10": {
5253
"reqol10_response_id": "1504524233",
53-
"reqol10_datetime": "2024-11-05 12:07:38.7956557+00:00",
54+
"reqol10_datetime": "2024-11-05T12:07:38.7956557+00:00",
5455
"reqol10_1_everyday_tasks_float": "3.0",
5556
"reqol10_2_trust_others_float": "2.0",
5657
"reqol10_3_unable_to_cope_float": "1.0",
@@ -66,7 +67,7 @@ def test_convert_generic(self):
6667
},
6768
"wsas": {
6869
"wsas_response_id": "1212115884",
69-
"wsas_datetime": "2024-11-05 12:08:48.0135908+00:00",
70+
"wsas_datetime": "2024-11-05T12:08:48.0135908+00:00",
7071
"wsas_1_work_float": "3.0",
7172
"wsas_2_management_float": "5.0",
7273
"wsas_3_social_leisure_float": "3.0",
@@ -84,6 +85,11 @@ def test_convert_generic(self):
8485
if q_code is not None and q_code not in done:
8586
with self.subTest(q_name=q_code):
8687
done.append(q_code)
88+
if q_code not in expectations.keys():
89+
if q_code == "consent":
90+
continue
91+
else:
92+
self.fail(f"Unhandled questionnaire response of type {q_code}.")
8793
result = convert_generic(r)
8894
self.assertEqual(expectations[q_code], result)
8995

@@ -98,6 +104,7 @@ def test_extract_info(self):
98104
responses = csv.DictReader(f, delimiter="|")
99105
response = next(responses)
100106
private, public = extract_participant_info(response)
107+
sleep(0.1)
101108
self.assertGreater(datetime.now().isoformat(), private["datetime"])
102109
self.assertGreater(datetime.now().isoformat(), public["info_datetime"])
103110
private["datetime"] = None

Diff for: trd_cli/conversions.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def convert_generic(questionnaire_response: dict) -> dict:
229229
prefix = questionnaire["code"]
230230
out = {
231231
f"{prefix}_response_id": str(questionnaire_response["id"]),
232-
f"{prefix}_datetime": str(questionnaire_response["submitted"]),
232+
f"{prefix}_datetime": str(questionnaire_response["interoperability"]["submitted"]),
233233
}
234234
scores = questionnaire_response["scores"]
235235
for i, k in enumerate(questionnaire["items"]):

0 commit comments

Comments
 (0)