Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 REGRESSION MEGATHREAD #941

Open
OxygenCobalt opened this issue Jan 7, 2025 · 178 comments
Open

4.0.0 REGRESSION MEGATHREAD #941

OxygenCobalt opened this issue Jan 7, 2025 · 178 comments
Assignees
Labels
megathread This is a megathread

Comments

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jan 7, 2025

SUBMIT REGRESSIONS AND PROBLEMS WITH 4.0.0 HERE!

Some already known issues:

  • Playback state is not persisting during the upgrade (I have yet to debug this due to time constraints) -> dev4
  • Weird bouncing effect when navigating to album song (Likely regression) -> dev4
  • Skipping effect when editing playlists -> dev4
  • Fix broken fab shadow -> dev4
  • Out of spec play/pause button -> dev4
  • Certain themes are functionally identical -> dev4
  • Broken home fast scroller when sorting by date added -> dev4
  • Playlist editing isn't working -> dev3
  • Cannot restart music loading -> dev3
  • Music linking crashes on some libraries with a NullPointerException -> dev3
  • No ID3v1 support -> dev3
  • Crash when loading FLAC files -> dev2
  • Playback controls fall behind queue bar (Unfixable system issue)
  • Predictive back can stop working when navigating through library (Likely library issue, cannot be fixed right now)

Some untested stuff:

  • Automatic reloading
  • Cover behavior edge cases
  • Long-term storage use by cover cache
  • M3U and Vorbis edge cases
@OxygenCobalt OxygenCobalt added the megathread This is a megathread label Jan 7, 2025
@OxygenCobalt OxygenCobalt self-assigned this Jan 7, 2025
@OxygenCobalt OxygenCobalt changed the title 4.0.0 regression megathread 4.0.0 REGRESSION MEGATHREAD Jan 7, 2025
@OxygenCobalt OxygenCobalt pinned this issue Jan 7, 2025
@OxygenCobalt OxygenCobalt mentioned this issue Jan 7, 2025
4 tasks
@grapheneloverdev
Copy link

#942

@dot166
Copy link
Contributor

dot166 commented Jan 8, 2025

#946 ( fixed in 58e0956 )

@grapheneloverdev
Copy link

One small issue: the fast scrolling slider isn't pressable when near the shuffle button.

@strongville
Copy link

Crashed on background with the following stack trace provided by the app itself (dev2 on Android 15):

android.app.ForegroundServiceStartNotAllowedException: Service.startForeground() not allowed due to mAllowStartForeground false: service org.oxycblt.auxio/.AuxioService
	at android.app.ForegroundServiceStartNotAllowedException$1.createFromParcel(ForegroundServiceStartNotAllowedException.java:54)
	at android.app.ForegroundServiceStartNotAllowedException$1.createFromParcel(ForegroundServiceStartNotAllowedException.java:50)
	at android.os.Parcel.readParcelableInternal(Parcel.java:5105)
	at android.os.Parcel.readParcelable(Parcel.java:5087)
	at android.os.Parcel.createExceptionOrNull(Parcel.java:3267)
	at android.os.Parcel.createException(Parcel.java:3256)
	at android.os.Parcel.readException(Parcel.java:3239)
	at android.os.Parcel.readException(Parcel.java:3181)
	at android.app.IActivityManager$Stub$Proxy.setServiceForeground(IActivityManager.java:7193)
	at android.app.Service.startForeground(Service.java:776)
	at org.oxycblt.auxio.AuxioService$$ExternalSyntheticLambda0.invoke(SourceFile:388)
	at org.oxycblt.auxio.AuxioService.updateForeground(SourceFile:202)
	at org.oxycblt.auxio.music.service.IndexingHolder.onIndexingStateChanged(SourceFile:5)
	at org.oxycblt.auxio.music.MusicRepositoryImpl.access$emitIndexingProgress(SourceFile:97)
	at org.oxycblt.auxio.music.MusicRepositoryImpl$emitIndexingProgress$1.invokeSuspend(Unknown Source:12)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:9)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:109)
	at androidx.core.app.ActivityRecreator$1.run(SourceFile:36)
	at kotlinx.coroutines.scheduling.TaskImpl.run(SourceFile:3)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(SourceFile:93)
	Suppressed: android.app.ForegroundServiceStartNotAllowedException: Service.startForeground() not allowed due to mAllowStartForeground false: service org.oxycblt.auxio/.AuxioService
		... 20 more

Also, after crashing, the library loading is as slow as the first time adding the folder to Auxio (not sure if it is the time it will take when closed normally or because of the same crash).

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented Jan 8, 2025

What do you mean in the background @strongville? Were you playing anything? Was Automatic Reloading on?

@strongville
Copy link

With background, I meant that I switched apps, but as it only happened once, I really don't remember if it really was like that (I could've left the app open on now playing screen).

The app was playing FLAC from an imported playlist.

Checking the settings, Automatic Reloading is off.

@OxygenCobalt
Copy link
Owner Author

Was it paused or not @strongville

@strongville
Copy link

Sorry, was not paused, the crash interrupted the playback.

@OxygenCobalt
Copy link
Owner Author

Wait, there are two errors here @strongville

Error 1 crashed the app and playback

Error 2 is a weird music loading error I have had a hard time tracking down since I believe it's an Android problem.

@strongville
Copy link

Yeah, was not sure how to report that, and at first stance looked related to me.

Thanks for checking out! I'll keep using dev versions and if I notice something else (or the same crash as error 1), I'll try to give more details how happened.

@VoxelPrismatic

This comment was marked as resolved.

@OxygenCobalt
Copy link
Owner Author

Didn't think this was enough for a full issue, so I'll put it here
4.0.0-dev3 - funky shadow
ResizedImage_2025-01-08_20-05-29_1973.png

Thanks, will fix with other UI stuff

@WreckingBANG
Copy link

Weird Date on all my Music. Everything seems to have the same really wrong Date.

Screenshot_20250109-195535

@VoxelPrismatic
Copy link

@WreckingBANG please share a couple sample files

@OxygenCobalt
Copy link
Owner Author

No @VoxelPrismatic, this is probably actually a bug with the fast scroller

@VoxelPrismatic
Copy link

I could not reproduce with my library, @OxygenCobalt

@OxygenCobalt
Copy link
Owner Author

It's related to date added support @VoxelPrismatic, I've noticed this error before I just haven't acted on it.

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented Jan 14, 2025

Most regressions I believe have been ironed out, a full 4.0.0 release is imminent.

Only remaining change might be to whether "Round mode" is enabled by default [Sharp covers will remain, however]. From what I've observed, more people turn Round mode on rather than off, so it seems to be the more sensible default on my end. It also is a much better companion to the new design. Once this decision is made I'll be prepared to finally launch.

@Fuoxden
Copy link

Fuoxden commented Jan 14, 2025

Most regressions I believe have been ironed out, a full 4.0.0 release is imminent.

Only remaining change might be to whether "Round mode" is enabled by default [Sharp covers will remain, however]. From what I've observed, more people turn Round mode on rather than off, so it seems to be the more sensible default on my end. It also is a much better companion to the new design. Once this decision is made I'll be prepared to finally launch.

Very Exciting news! I can't wait for the full 4.0.0 release!

@e-zk
Copy link
Contributor

e-zk commented Jan 14, 2025

#960 :(
Occurring after updating to dev-4

@e-zk e-zk mentioned this issue Jan 14, 2025
4 tasks
@Richard38907
Copy link

Richard38907 commented Jan 15, 2025

since 4.0.0 bottom android navigation bar has an ugly black background instead of the transparent one present on 3.x.x.
Screenshot_20250115-111652.png

Screenshot_20250115-150558.png

This black bar is only present on the menus.

@VoxelPrismatic
Copy link

since 4.0.0 bottom android navigation bar has an ugly black background instead of the transparent one present on 3.x.x.

This black bar is only present on the menus.

I can't reproduce this, on any set/auto theme or system light/dark theme.
Screenshot_20250115-081824.png

Sony Xperia 1 V; Android 15 (OEM); Auxio 4.0.0-dev4

@Richard38907
Copy link

Richard38907 commented Jan 15, 2025

Strange, I have this black bar on my two OnePlus ( OxygenOS and AOSP roms)🤔
This behaviour happens with all themes activated (light, dark and pure black)

@VoxelPrismatic
Copy link

What's your build?
ResizedImage_2025-01-15_09-37-06_4509.png

@Alex-mainGit
Copy link

Any chance for the ability to exclude certain folders instead of adding music folders to be reincluded in version 4? Previous versions had that option but with version 4 it went away.

@OxygenCobalt
Copy link
Owner Author

@Username1-a Material Design 3 requires me to have elevated colors in bottom sheet components (like the playback view). I tone them down in black mode, but your dynamic theme palette is really weird. It should not be looking like that where the main playback sheet is brighter than the queue sheet. Are you using some custom ROM theme palette generator? I don't officially support those since they completely break the theme palette API to force some arbitrary theming rather than using Monet.

@OxygenCobalt
Copy link
Owner Author

My material you colors are not being applied to the ui.

@anonymousaga Do you use a custom ROM? That looks a lot like a custom theme generator. In Android 15 a bunch of new system colors were added that represented specific color roles (like "color_surface") rather than individual palette colors. When I updated to the latest Material Design it uses those from Android 15 onwards, and so if your theme generator isn't populating those colors it's going to use some default. Would highly recommend reporting this issue to whatever ROM you're using.

The most I can do on my end is manually copy over the old hardcoded palette. Annoying, but feasible.

@OxygenCobalt
Copy link
Owner Author

Is there a way to exclude the "/Music/Recordings" subfolder in version 4.0+? Please forgive me if this is off-topic and thanks in advance.

Okay, folder exclusion is seemingly still needed in Auxio, will re-add @unipoco

@OxygenCobalt
Copy link
Owner Author

Same i have a ton of music but for me instead of Auxio loading the created library (database) like prior in 3.6.X it goes and rescans my whole music instead which takes a seriously long time

Auxio uses an entirely new metadata extractor and file loading system, requiring me to repopulate the entire database @DemonoidMaster. Sorry.

@anonymousaga
Copy link

My material you colors are not being applied to the ui.

@anonymousaga Do you use a custom ROM? That looks a lot like a custom theme generator. In Android 15 a bunch of new system colors were added that represented specific color roles (like "color_surface") rather than individual palette colors. When I updated to the latest Material Design it uses those from Android 15 onwards, and so if your theme generator isn't populating those colors it's going to use some default. Would highly recommend reporting this issue to whatever ROM you're using.

The most I can do on my end is manually copy over the old hardcoded palette. Annoying, but feasible.

I am still on android 14 and have not restyled since android 13. Its not a custom rom, just the app repainter + adb. Ill update to 15 when it releases stable and then I will restyle, hopefully that fixes it. Thanks!

@OxygenCobalt
Copy link
Owner Author

Actually that's weird. AFAIK A14/A13 uses should be using the same palettes that should be available. Implies that MDC has some other bug, will figure out how to debug @anonymousaga

@anonymousaga
Copy link

I just restyled with a newer app (ColorBlendr) and it filled in all the colors, and auxio is themed now. The old app (repaintr) was last updated 3 years ago. There is no bug in auxio. Thanks for you help.

@OxygenCobalt
Copy link
Owner Author

@unipoco Tracking #1037 to re-add the ability to exclude folders in-app. Not sure how the UI will work.

@jsgibson
Copy link

Sorting albums by date added is no longer working. It just sorts by album name. Other sorting options seem to be working.

@OxygenCobalt
Copy link
Owner Author

Sorting albums by date added is no longer working. It just sorts by album name. Other sorting options seem to be working.

I can no longer reasonably access system date added with SAF now, I have to use an in-app timestamp, sorry @jsgibson

@Username1-a
Copy link

@OxygenCobalt
Was using Repainter previously (since it's still works amazing on apps without updated material components and that don't have their own Black theme implemented),
but even without it (Just bland stock Monet), Now Playing background on Black theme just too bright. Making it pure black for Black theme just would look better, so maybe consider transitioning grey collapsed player background color to pure black background when expanded into Now Playing screen (Version 3.6.3 did exactly that, some examples attached)
Image
Image

Image

@OxygenCobalt
Copy link
Owner Author

Okay, I looked at the design guidelines again and it turns out I'm wrong, I should be deelevating the bottom sheet when it goes full screen. Will probably switch back the old fade out then to some extent, not sure how

@lineinthesand
Copy link

#1046

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented Mar 15, 2025

Okay, I don't think I can actually meaningfully dim the sheet without:

  • Extreme technical complexity yielding an unstable UI
  • A very weird user experience where the queue sheet goes from blending in with the playback sheet to actually sticking out of it
  • The predictive back gestures causing the sheet to blend in with the main app and simply look odd
  • Completely off-spec queue sheet elevation

Sorry @Username1-a.

@OxygenCobalt
Copy link
Owner Author

Going to retire this issue probably a few days from v4.0.4 hitting F-Droid, seems like most regressions have or will so be ironed out.

@sioodmy
Copy link

sioodmy commented Mar 20, 2025

you did an amazing job

@VoxelPrismatic
Copy link

VoxelPrismatic commented Mar 20, 2025

Hey OcyCblt, I'm just curious about something. On my older Samsung, when I was streaming to my car via bluetooth, it had the options to set shuffle and repeat modes. I'm curious if that is an android modification, or something that can be set up within the app, as it no longer works with my new Sony. I was using Samsung Music at the time, so it isn't something necessarily wrong with Auxio.

I don't know how it works in Android, but for Linux (using Freedesktop's MPRIS API), I just had to implement a listener for those events. I also know that VLC and KDE Connect do their level best to support everything, and shuffle/repeat are not available options there.

Also, if my car doesn't display album covers, is that because the album cover is too large, the car doesn't support displaying custom photos, or because the app doesn't support sharing photos? I ask this because I replace all my FLAC album covers with the 2500x2500 version included from Bandcamp, but the only album cover my car displays is from Magnolia, but the album cover shown in my car curiously does not exist in any of the FLAC files, and it isn't styled like one of the built-in genre covers.

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented Mar 21, 2025

@VoxelPrismatic

There is a ton of hidden android internals between Auxio and your car so I don't really know what's happening in practice. AFAIK Auxio should be capable of handling AVRPC (the bluetooth media command protocol) via the system media framework, which should allow shuffle/repeat and cover art, but maybe I configured something wrong or missed a magic flag I need to set. Car ROMs media support are horribly flaky and out of my control. If you can try out some of the other OSS media players and see if they work, let me know and I'll make issues since it's an Auxio bug rather than absurd system behavior.

And yeah, wouldn't be shocked Samsung patched in synergistic behavior w/their ROM apps. Google is guilty of it too with how they systematically promote their apps alongside Google Play Services.

@DemonoidMaster
Copy link

@VoxelPrismatic

There is a ton of hidden android internals between Auxio and your car so I don't really know what's happening in practice. AFAIK Auxio should be capable of handling AVRPC (the bluetooth media command protocol) via the system media framework, which should allow shuffle/repeat and cover art, but maybe I configured something wrong or missed a magic flag I need to set. Car ROMs media support are horribly flaky and out of my control. If you can try out some of the other OSS media players and see if they work, let me know and I'll make issues since it's an Auxio bug rather than absurd system behavior.

And yeah, wouldn't be shocked Samsung patched in synergistic behavior w/their ROM apps. Google is guilty of it too with how they systematically promote their apps alongside Google Play Services.

Voxel could try fiddling with the AVRPC in developer settings in android and see if setting it to any specific version might work with the car, also vice-versa in that car dash too if it's an android based car dash that can have dev settings enabled

@VoxelPrismatic
Copy link

Oh, it turns out that Auxio has absolutely nothing to do with anything whatsoever. Android just does what the hell it wants.

Screenshot_20250321-213050.png

20250321_213421.JPG

@OxygenCobalt
Copy link
Owner Author

Real @VoxelPrismatic, looks like an android-based car ROM. Perhaps they are phoning home for a online cover art via some service (lastfm, musicbrainz, coverart.org).

@VoxelPrismatic
Copy link

@OxygenCobalt The fake album covers are one thing, but between the three cars I've tried, none displayed album covers properly.

@OxygenCobalt
Copy link
Owner Author

Weird, unless you can find an OSS music player that does I can't really figure out what I can do on my end @VoxelPrismatic

@VoxelPrismatic
Copy link

I'm going to assume that Android is simply incapable of doing anything properly.

@spring-dependency-management
Copy link

spring-dependency-management commented Mar 29, 2025

Pressing shuffle button causes quite a noticeable lag spike when you have a lot of songs (>5000)

@spring-dependency-management

under certain situations the lock screen player won't skip songs when you press the skip button, sometimes you need to press multiple times, not sure how to accurately replicate, there is also small possibility i have fat fingers

@spring-dependency-management

Loading the app after boot, the initializing feels slower/similar speed with around 10,000 songs, although this may be exasperated by the song list appearing empty during loading, I don't think it did in 3.0?
Also I may be wrong but 4.0 doesn't allow you to start searching until song list is fully loaded?

@Martysh12
Copy link
Contributor

The layout looks a bit messed up on my tablet.
Screenshot_20250330-170415.png

@Martysh12
Copy link
Contributor

oh it looks like the grey rectangle is an absolutely huge separator lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
megathread This is a megathread
Projects
None yet
Development

No branches or pull requests