New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial value VariableAttributes should be optional #90

Open

sjdaines opened this issue May 13, 2023 · 0 comments

Member

sjdaines commented May 13, 2023 •

edited

Loading

:initial_value, :norm_value, :initial_delta are currently marked as 'required' so are present on every Variable with default values.

These should be optional and only added to state Variables etc by the Reactions that create these and are planning to handle them.

This would improve robustness (generate an error if a configuration file attempted to set :initial_value on the wrong variable).

NB: this would be a breaking change as Reaction code that defines new reservoir types etc in other packages will need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment