Skip to content

Commit a9a9f87

Browse files
committed
fix unnecessary type-specs that cause problems for Inplace - PDLPorters/pdl#511
1 parent a87b631 commit a9a9f87

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

Changes

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
- moved TS::diff (unused here) to Ufunc
33
- move PDL::Stats::Distr into PDL::GSL since needs GSL
44
- minimum 5.16 as some 5.15 broke PDL::Stats (https://github.com/Perl/perl5/issues/11835)
5+
- fix unnecessary type-specs that cause problems for Inplace (https://github.com/PDLPorters/pdl/issues/511)
56

67
0.84 2024-05-27
78
- effect_code exception if only one unique value

GLM/glm.pd

+10-10
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ pp_addhdr('
6161
);
6262

6363
pp_def('fill_m',
64-
Pars => 'a(n); float+ [o]b(n)',
64+
Pars => 'a(n); [o]b(n)',
6565
Inplace => 1,
6666
GenericTypes => [F, D],
6767
HandleBad => 1,
@@ -165,7 +165,7 @@ The output pdl badflag is cleared.
165165
);
166166

167167
pp_def('dev_m',
168-
Pars => 'a(n); float+ [o]b(n)',
168+
Pars => 'a(n); [o]b(n)',
169169
Inplace => 1,
170170
GenericTypes => [F, D],
171171
HandleBad => 1,
@@ -191,7 +191,7 @@ Replaces values with deviations from the mean. Can be done inplace.
191191
);
192192

193193
pp_def('stddz',
194-
Pars => 'a(n); float+ [o]b(n)',
194+
Pars => 'a(n); [o]b(n)',
195195
Inplace => 1,
196196
GenericTypes => [F, D],
197197
HandleBad => 1,
@@ -221,7 +221,7 @@ Standardize ie replace values with z_scores based on sample standard deviation f
221221
);
222222

223223
pp_def('sse',
224-
Pars => 'a(n); b(n); float+ [o]c()',
224+
Pars => 'a(n); b(n); [o]c()',
225225
GenericTypes => [F, D],
226226
HandleBad => 1,
227227
Code => '
@@ -240,7 +240,7 @@ Sum of squared errors between actual and predicted values.
240240
);
241241

242242
pp_def('mse',
243-
Pars => 'a(n); b(n); float+ [o]c()',
243+
Pars => 'a(n); b(n); [o]c()',
244244
GenericTypes => [F, D],
245245
HandleBad => 1,
246246
Code => '
@@ -262,7 +262,7 @@ Mean of squared errors between actual and predicted values, ie variance around p
262262
);
263263

264264
pp_def('rmse',
265-
Pars => 'a(n); b(n); float+ [o]c()',
265+
Pars => 'a(n); b(n); [o]c()',
266266
GenericTypes => [F, D],
267267
HandleBad => 1,
268268
Code => '
@@ -284,7 +284,7 @@ Root mean squared error, ie stdv around predicted value.
284284
);
285285

286286
pp_def('pred_logistic',
287-
Pars => 'a(n,m); b(m); float+ [o]c(n)',
287+
Pars => 'a(n,m); b(m); [o]c(n)',
288288
GenericTypes => [F, D],
289289
HandleBad => 1,
290290
Code => '
@@ -312,7 +312,7 @@ Calculates predicted prob value for logistic regression.
312312
);
313313

314314
pp_def('d0',
315-
Pars => 'a(n); float+ [o]c()',
315+
Pars => 'a(n); [o]c()',
316316
GenericTypes => [F, D],
317317
HandleBad => 1,
318318
Code => '
@@ -343,7 +343,7 @@ Null deviance for logistic regression.
343343
);
344344

345345
pp_def('dm',
346-
Pars => 'a(n); b(n); float+ [o]c()',
346+
Pars => 'a(n); b(n); [o]c()',
347347
GenericTypes => [F, D],
348348
HandleBad => 1,
349349
Code => '
@@ -370,7 +370,7 @@ Model deviance for logistic regression.
370370
);
371371

372372
pp_def('dvrs',
373-
Pars => 'a(); b(); float+ [o]c()',
373+
Pars => 'a(); b(); [o]c()',
374374
GenericTypes => [F, D],
375375
HandleBad => 1,
376376
Code => '

0 commit comments

Comments
 (0)