PDL::IO::Dumper: better handling of multiply referenced ndarrays #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a structure like this returns undef for duplicated entries, as well as raising "my variable masking" warnings when evaled back. my $p = zeroes (5); my $arr = [$p, $p];
This also avoids "my variable masking" warnings when eval'ing smaller ndarrays back to a structure. Warnings for larger uuencoded strings are not yet handled.
It interferes with uuencoded strings. Temporary change.
* Use named lexical as the loop variable * Unpack all args at start * Some whitespace changes
Shift most of the work to an internal sub which works with an array instead of strings. This avoids problems with deduplication when structures span more than one line.
This allows us to pass the seen hash as an arg and dedup as we go. Should save memory for large structures.
Don't serialise an ndarray that has already been processed. This avoids the need to deduplicate later, although that process is retained just in case it is useful.
The threshold for using uuencode may change in future given 25x25 is not that large these days. Do the same for the small threshold used to determine if the struct should be inlined.
|
Superb, thanks! Seeing the test code tells me I need to adjust that to use Test::PDL as well. |
mohawk2
added a commit
that referenced
this pull request
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some modernisation of code. More could be done but that's better as a separate PR.
Fixes #508