-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification/specification of order of condition changes required #557
Comments
Hmm, interesting point. I would prefer to assume that volume changes always take precedence over concentration changes. |
Agreed, that needs to be clarified.
This is also what would happen if an SBML model has an InitialAssignment for both the initial concentration and the respective compartment size, right? Sounds good then. |
SBML level 3 version 2 release 2:
|
would propose to handle this the same way as for simultaneous assignment of volume size & concentration:
|
This is the same issue as in SBML Events with multiple EventAssignments based on a trigger (i.e. this has been solved already for events and the same solution should be used here). 4.12.5 EventAssignment
In SBML all event assignments are performed simultaneously. The same should happen in PEtab for all the model changes for a given condition. I.e. there is no order of execution. All changes are applied at once. |
Depending on the order of the changes applied for a condition the model will be in a different state. I.e. the order of the columns matters in the condition table.
E.g. a model with species
S
in compartmentC
with an initial concentration of 1.0. If you change first the VolumeC
and then the initial concenctration[S0]
, the model has different values for[S0]
compared to first changing concentration and then volume.Currently it states
This should be changed to:
See also for instance: AMICI-dev/AMICI#2062
The text was updated successfully, but these errors were encountered: