-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify meaning of initializationPrior*
#587
Comments
Reminds me that that I once found this a little bit confusing. In my mind, it would make sense to treat the following explicitly separately
|
This is already separated. Those are the
This would be
Everything for plotting is the visualization table, but this is currently independent of any prior distributions. |
I was not talking about those columns specifically, more about my experience when I was new to optimization and first came across PEtab. I was not quite sure how to cast the data I had into an objective function (should I just use least squares?), but after reading the format specification, thinking about it and reading it again, it all started to make sense - except for the two |
For me, whenever a new point is sampled in an uninformed way, then the I also agree with @paulflang that the columns that define the objective function should be obvious, so then This information is useful but could also be shifted to the PEtab Result format. Currently, there are no (draft) guidelines for whether certain optimizer information is better suited in optional columns in PEtab, or as values in the PEtab Result. |
This sounds reasonable, in principle. However, my problem is, that for certain global optimizers it will be difficult to achieve that. They usually just take some box constraints and then sample randomly inside the box. |
This means we would need multiple PEtab problems, one per optimizer type (local/global). It also means one would need to use the same optimizer type to reproduce a result with the original PEtab problem -- otherwise, manual changes would be needed to have a valid PEtab problem. I guess from the perspective of PEtab users, it might be more useful to be able to specify information that an optimizer can use, without requiring it. Or, we move/copy this to the PEtab Result. |
:-/
Agreed, but then it should be made clear in the documentation that it's just some hint that optimizers may or may not use. Possibly also in the column name.
That sounds wrong, since it clearly is input, not output. Whether it was used to obtain the given result could be included there. |
Agreed re: input vs. output. My message was coming from the perspective "the PEtab Result aims to store sufficient information for reproducibility of a result", rather than "the PEtab Result should only contain the result". i.e. it's currently planned that the PEtab Result contains inputs like optimizer hyperparameters and other tool-specific settings. But fine to leave out of this discussion. |
Initially,
initializationPriorType
andinitializationPriorParameters
were introduced to provide prior distributions for sampling initial points in a multi-start optimization setting. For other global optimization schemes it is less clear how this should be incorporated. Not at all? For the initial population? Whenever a new point is sampled? ...?The text was updated successfully, but these errors were encountered: