Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shieleded address as refund address for piv cards? #333

Open
borris345 opened this issue Apr 4, 2024 · 4 comments
Open

Shieleded address as refund address for piv cards? #333

borris345 opened this issue Apr 4, 2024 · 4 comments

Comments

@borris345
Copy link

Is this possible? Doesn't work currently

@JSKitty
Copy link
Member

JSKitty commented Apr 4, 2024

PIVCards uses PIVX Core as it's payment processing backend (not MyPIVXWallet, so not relevant to this repository), unfortunately PIVX Core lacks the features needed to implement SHIELD Refund Addresses to PIVCards, PIVCards relies on raw UTXO management, which PIVX Core doesn't expose for SHIELD I believe.

It would likely require a complex rewrite of how PIVCards runs accounting, or a small-ish rewrite with the cost overhead of an additional SHIELD-only daemon to process SHIELD Txs.

@borris345
Copy link
Author

The cost of privacy for that extra transaction. I'd say worth it

@JSKitty
Copy link
Member

JSKitty commented Apr 4, 2024

I'll likely implement it using the dual-server proxy method and slightly bump our server proposal for it, but it'd be much easier on our infrastructure if PIVX Core just supported spending individual SHIELD notes in a raw fashion, may create a PIVX Core issue requesting it, it would half the costs of PIVCards maintenance and half the failure points for PIVCards.

Also to clarify: even with the dual-server model, PIVCards can't use SHIELD addresses in orders themselves, this can only enable SHIELD refunds, PIVX Core is simply missing the features we need to implement that with our payments system, we need a SHIELD-equivalent of createrawtransaction.

@JSKitty
Copy link
Member

JSKitty commented Apr 4, 2024

Quick update on this: talked with Fuzzbawls and actually we may be able to pull this off better than I thought, there are alternative RPCs (with some minor functionality differences) that should in theory allow us to change PIVCards fully to SHIELD (Order payments and Refund Addresses), we'll experiment with a full SHIELD-only implementation next week and see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants