Skip to content

Commit 2433543

Browse files
authored
Merge pull request #89 from kinow/running-tests
Avoid creating file in user desktop, fix typos and tests location
2 parents ea26d97 + 0f2fc7b commit 2433543

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

janis_core/tests/test_translation_wdl.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import unittest
2+
from tempfile import TemporaryDirectory
23
from typing import Optional
34

45
from janis_core.deps import wdlgen
@@ -1600,7 +1601,8 @@ def test_file_int_fail(self):
16001601

16011602
class TestForEachSelectors(unittest.TestCase):
16021603
def test_minimal(self):
1603-
TestForEach().translate("wdl", to_disk=True, export_path="~/Desktop/tmp")
1604+
with TemporaryDirectory() as tmpdir:
1605+
TestForEach().translate("wdl", to_disk=True, export_path=tmpdir)
16041606
w, _ = WdlTranslator.translate_workflow(TestForEach())
16051607
expected = """\
16061608
version development

janis_core/translations/translationbase.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def __str__(cls):
6464

6565
class TranslatorBase(ABC):
6666
"""
67-
So you're thinking about adding a new tWranslation :)
67+
So you're thinking about adding a new translation :)
6868
6969
This class will hopefully give you a pretty good indication
7070
on what's required to add a new translation, however what I
@@ -88,7 +88,7 @@ class TranslatorBase(ABC):
8888
and then write unit tests to cover each component of the translation
8989
and then an integration test of the whole translation on the related workflows.
9090
91-
You can find these in /janis/tests/test_translation_*.py)
91+
You can find these in /janis_core/tests/test_translation_*.py)
9292
"""
9393

9494
__metaclass__ = TranslatorMeta

requirements/documentation.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
-r base.txt
22
Sphinx==1.8.2
33
sphinx-autobuild==0.7.1
4-
tabulate==0.8.2
4+
tabulate

0 commit comments

Comments
 (0)