Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review Comments #46

Open
cramacha opened this issue Dec 6, 2024 · 0 comments
Open

JOSS Review Comments #46

cramacha opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cramacha
Copy link

cramacha commented Dec 6, 2024

Hello,

I am one of the reviewers tasked with reviewing your submission for JOSS (See issue: openjournals/joss-reviews#7563) and I have a minor list of comments that could be addressed to improve the quality of the project.

  1. In the README file, you don't mention the usage of get-files-by-project-accession, get-private-files, get-projects. It would be nice to add details about those.
  2. In the README, it would be useful to mention how one can contribute to the repo.
  3. In the paper, you have done an exercise of performing a benchmark of download speeds for different protocols. Did you do any exercise comparing your tool with any similar tool?
  4. Is there any documented list of future enhancements that could be done for the tool? For example, maybe you could improve download speeds or perhaps implement a GUI for managing clients and downloads.
  5. I am being nitpicky here, but in your LICENSE file, I think you may need to replace the generic "Copyright [yyyy] [name of copyright owner]" with the actual owners?
  6. It would be useful to add more comments on these files: https://github.com/PRIDE-Archive/pridepy/blob/master/pridepy/pridepy.py explaining the purpose and overall usage. Another place is here: https://github.com/PRIDE-Archive/pridepy/blob/master/pridepy/project/project.py. You could add missing comments as needed.

Otherwise, thanks for the opportunity to review this code.

@ypriverol ypriverol self-assigned this Dec 7, 2024
@ypriverol ypriverol added enhancement New feature or request help wanted Extra attention is needed labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants