-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete rebuild of build system #284
Comments
I rather like poetry! But I don't have a strong preference if you do. What's the alternative? (I don't think that plain pip is fun, because it can't generate a lockfile). |
What about pdm or pip-tools? |
I just checked out PDM, looks interesting. I don't know it well. IME pip-tools is OK but a worse version of poetry... But does poetry have a downside? It's not perfect, but it has served me very well over the past few years. It it so much easier than before it arrived... If you have a strong view for PDM then I'm open to moving. The current break on python 3.12 is that greenlet package. poetry will tell us where that comes from, I can have a look.
The biggest impact of a lock file in python is fixed dependencies when developing and testing. Over at xarray (where I first started doing more serious open-source work), we use conda. And it's quite inconvenient, because our tests on Does that make sense? |
(one benefit of poetry is that it works with dependabot; I'm not sure whether the others do?) |
Recently CI suddenly started failing, apparently due to the fact that they had previously installed the latest jupysql 0.10 and now they have 0.7 installed and that is why it is failing. Looking at the differences in the lock file, it appears that jupysql 0.7.2 was added by #286. How about moving to Hatch? https://github.com/pypa/hatch |
+1, quite confusing. FWIW I haven't had this before with poetry, but this did seem bad.
I'm open to it! If you think it's better, I'm fine to move. It does look like a well-managed project. One downside is losing dependabot. But possibly they'll make dependabot compatibility in the future. |
@max-sixty I think you made a mistake merging #429 as a fix, #429 is not a fix. I'm really tired of using the bizarre build system of this repository, where we can't release correctly if we get the PR title wrong, and poetry just seems to complicate the dependency issue. |
Some thoughts:
|
Sorry this is falling on you — I apologize for my part. I also agree that people are liable (at least me!) to get the prefix wrong. Keen to move to |
python-semantic-release
(See chore: bump prql-python from 0.9.0 to 0.10.0 #283 (comment))poetry
(See chore: update Python and poetry #270 (comment))The text was updated successfully, but these errors were encountered: