-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make packages (pandas) optional #374
Comments
One problem with using optional packages in pip is that they're quite rarely used — unlike rust. So IME most users aren't familiar with how to install them / that they should check which set of dependencies they want. We do have If there is a large enough use case for splitting the dependencies here, then OK, but otherwise I would leave away from it. Maybe pandas is that? But also most installations would have pandas anyway... |
Just as great_tables recently removed both pandas and polars from its required dependencies (technically, it removed pandas, which was once a required dependency, to support polars-only installation), polars users may not want to install pandas. Currently pyprql pulls pandas and duckdb, while these are completely unnecessary for users who want to use only polars. As like the discussion of making pyarrow a required dependency of pandas seems to be (pandas-dev/pandas#57073), I think packages with huge binaries tend to be shunned. |
Certainly jupysql and duckdb are worth keeping for now, but pandas is really unnecessary. |
This is a very good point! Because this augments pandas' functionality but doesn't otherwise require pandas to work, we could even remove it from the dependencies all together. Then if someone has pandas / polars installed, this library augments that, otherwise it doesn't interfere by installing anything. (We'd still have them in dev dependencies so tests can run etc. And OK if you prefer to have them as optional dependencies) |
I would like to change all dependencies except
prqlc
to optional so that we can install only what we need likepyprql[pandas]
orpyprql[jupyter]
.In many cases pandas are no longer needed, especially when polars are added to the dependency by #373.
The text was updated successfully, but these errors were encountered: