Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyprql no longer runs in Google Colab #381

Closed
snth opened this issue May 6, 2024 · 5 comments
Closed

pyprql no longer runs in Google Colab #381

snth opened this issue May 6, 2024 · 5 comments

Comments

@snth
Copy link
Member

snth commented May 6, 2024

Google Colab has changed something and installing pyprql now causes the runtime to crash and it's unable to reconnect.

I think it's actually because of the ipython dependency. Do we need that for anything actually or is that just a convenience? If it's the latter then could we remove it please?

I thought it might be required by jupysql but that does not appear to be the case and the following notebook runs fine on Colab: https://colab.research.google.com/drive/1eOA2FYHqEfZWLYssbUxdIpSL3PFxWVjk?usp=sharing#scrollTo=siVry2OI7HwF

@eitsupi WDYT?

@max-sixty
Copy link
Member

Do you have a repro? I get this warning but it does seem to run (lightly edited your link with a snippet from the readme):

image

max-sixty added a commit that referenced this issue May 6, 2024
@eitsupi
Copy link
Member

eitsupi commented May 6, 2024

I think it's actually because of the ipython dependency. Do we need that for anything actually or is that just a convenience? If it's the latter then could we remove it please?

See #374.
I agree with making it an optional dependency.

@snth
Copy link
Member Author

snth commented May 6, 2024

Ah interesting, so I get this popup about needing to restart the session. When I do that then it can't reconnect to the session again. However if you just ignore it and don't restart then it runs fine.

Here's a link to a sample Notebook but I wasn't getting past cell 1 before.
https://colab.research.google.com/drive/18eQDq9X7sDZ7XDjeE6njI4XAD7MyuGGr?usp=sharing

image

@max-sixty
Copy link
Member

I think this should be fixed by #383

@max-sixty
Copy link
Member

Indeed, !pip install git+https://github.com/PRQL/pyprql.git now works

Thanks for the issue + the repro @snth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants