-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prql
namespace for polars.DataFrame and polars.LazyFrame
#373
Conversation
prql
sub name space for polars.DataFrame and polars.LazyFrameprql
sub namespace for polars.DataFrame and polars.LazyFrame
prql
sub namespace for polars.DataFrame and polars.LazyFrameprql
namespace for polars.DataFrame and polars.LazyFrame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool!
No objection to starting this as an optional dependency. We can then promote it if it turns out to be used lots. (I had a bit more objection in #374 to making everything optional).
Another option is to detect whether polars is installed in pyprql.__init__
and add the namespace without having to import pyprql.polars_namespace
— depends on the polars norms.
That seems like a good idea, but I don't know if it is good practice to do that here. |
For sure
It would be something like this in the
|
Close #371