Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed/unsigned support? #10

Open
gmarinov opened this issue Feb 4, 2023 · 0 comments
Open

signed/unsigned support? #10

gmarinov opened this issue Feb 4, 2023 · 0 comments

Comments

@gmarinov
Copy link

gmarinov commented Feb 4, 2023

Congrats on keeping wavefile alive.

Looks like.fromScratch() forces the signed flag of the file automatically from bit depth and format?

updateDataType_() {
this.dataType = {
bits: ((parseInt(this.bitDepth, 10) - 1) | 7) + 1,
fp: this.bitDepth == "32f" || this.bitDepth == "64",
signed: this.bitDepth != "8",
be: this.container == "RIFX"
};
if (["4", "8a", "8m"].indexOf(this.bitDepth) > -1) {
this.dataType.bits = 8;
this.dataType.signed = false;
}
}

Do you plan to support signed 8-bit and unsigned 16-bit audio?
Would be useful to write in the docs that it forces the format if not.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant