Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

Consider revision of FIRuncFilter #175

Open
mgrub opened this issue Oct 16, 2020 · 0 comments
Open

Consider revision of FIRuncFilter #175

mgrub opened this issue Oct 16, 2020 · 0 comments
Assignees

Comments

@mgrub
Copy link
Contributor

mgrub commented Oct 16, 2020

Currently, FIRuncFilter allows to hand over a low-pass blow to pre-filter the signal before the actual FIR-application. This is in line with the underlying paper.

Because blow is just a another FIR-filter, I could image a re-implementation that recoursivly calls FIRuncFilter if blow is given. This should reduce the complexity of the code. However, this would then deviate somewhat from the equations stated in the underlying paper.

Also, rigorously testing is required, so that we can assure that this is just a refactoring.

@mgrub mgrub self-assigned this Oct 16, 2020
mgrub added a commit that referenced this issue Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant