Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - Low Severity Issues #2

Open
Kogaroshi opened this issue Mar 31, 2023 · 0 comments
Open

Audit - Low Severity Issues #2

Kogaroshi opened this issue Mar 31, 2023 · 0 comments

Comments

@Kogaroshi
Copy link
Contributor

L01 : cf36d0590369de8d695661cbe51bfcca54a489cd
L02 : c9051b4f382d4497ecc2a47afd36a48d5e06a1a7
L03 : 4b5a107a5b65250ffd86484010226b2ed5f579c6
L04 : The code is duplicated to allow to revert with 2 customs Errors, which the totalAvailable() method cannot provide, since it ignores those error cases and return 0 instead => not making changes for this issue
L05 : Not making changes for this issue
L06 : 132bc388be79a4d7d8f71e083b683f83a6d8bb42
L07 : 3db1df87533f003c452774c560f3d217f0bd1d67
L08 : 10c66a275caa95e9df42c128424c96c31c5a8921
L09 : 56d723c72afde8d0c05e5e1bd3f94b82eebf3698 for applied changes, others were left the current way

N01 : The bufferRatio is applied on user funds held by the Vault, and not protocol owned part of the Vault (represented by reserveAmount), which is why the reserveAmount is not included in the bugger calculations. The totalRentedAmount is included, even if it is not current protocol solvency (as it is rented), it is users owned assets, which need to be part of the buffer calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant