Skip to content

Commit fbfd33c

Browse files
committed
lint & format fix
1 parent cb60d2c commit fbfd33c

File tree

2 files changed

+52
-26
lines changed

2 files changed

+52
-26
lines changed

switchmap/poller/async_poll.py

Lines changed: 50 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ async def devices(max_concurrent_devices=None):
2828
Returns:
2929
None
3030
"""
31-
3231
# Initialize key variables
3332
arguments = []
3433

@@ -53,29 +52,36 @@ async def devices(max_concurrent_devices=None):
5352
log.log2info(1400, log_message)
5453
return
5554

56-
log_message = f"Starting async polling of {len(arguments)} devices with max concurrency: {max_concurrent_devices}"
55+
log_message = (
56+
f"Starting async polling of {len(arguments)} devices "
57+
f"with max concurrency: {max_concurrent_devices}"
58+
)
5759
log.log2info(1401, log_message)
5860

5961
# Semaphore to limit concurrent devices
6062
device_semaphore = asyncio.Semaphore(max_concurrent_devices)
6163

6264
async with aiohttp.ClientSession() as session:
63-
tasks = [
64-
device(argument, device_semaphore, session, post=True) for argument in arguments
65+
tasks = [
66+
device(argument, device_semaphore, session, post=True)
67+
for argument in arguments
6568
]
6669
# Execute all devices concurrently
67-
start_time = time.time()
68-
results = await asyncio.gather(*tasks, return_exceptions=True)
69-
end_time = time.time()
70+
start_time = time.time()
71+
results = await asyncio.gather(*tasks, return_exceptions=True)
72+
end_time = time.time()
7073

7174
# Process results and log summary
7275
success_count = sum(1 for r in results if r is True)
7376
error_count = sum(1 for r in results if isinstance(r, Exception))
7477
failed_count = len(results) - success_count - error_count
7578

76-
log_message = f"Polling completed in {end_time - start_time:.2f}s: {success_count} succeeded, {failed_count} failed, {error_count} errors"
79+
log_message = (
80+
f"Polling completed in {end_time - start_time:.2f}s: "
81+
f"{success_count} succeeded, {failed_count} failed, "
82+
f"{error_count} errors"
83+
)
7784
log.log2info(1402, log_message)
78-
7985
# Log specific errors
8086
for i, result in enumerate(results):
8187
if isinstance(result, Exception):
@@ -84,18 +90,18 @@ async def devices(max_concurrent_devices=None):
8490
log.log2warning(1403, log_message)
8591

8692

87-
async def device(poll_meta, device_semaphore, session,post=True):
88-
"""Poll each device asynchoronously.
93+
async def device(poll_meta, device_semaphore, session, post=True):
94+
"""Poll each device asynchronously.
8995
9096
Args:
9197
poll_meta: _META object containing zone, hostname, config
9298
device_semaphore: Semaphore to limit concurrent devices
99+
session: aiohttp ClientSession for HTTP requests
93100
post: Post the data if True, else just print it
94101
95102
Returns:
96103
bool: True if successful, False otherwise
97104
"""
98-
99105
async with device_semaphore:
100106
# Initialize key variables
101107
hostname = poll_meta.hostname
@@ -105,7 +111,10 @@ async def device(poll_meta, device_semaphore, session,post=True):
105111
# Do nothing if the skip file exists
106112
skip_file = files.skip_file(AGENT_POLLER, config)
107113
if os.path.isfile(skip_file):
108-
log_message = f"Skip file {skip_file} found. Aborting poll for {hostname} in zone '{zone}'"
114+
log_message = (
115+
f"Skip file {skip_file} found. Aborting poll for "
116+
f"{hostname} in zone '{zone}'"
117+
)
109118
log.log2debug(1404, log_message)
110119
return False
111120

@@ -140,15 +149,25 @@ async def device(poll_meta, device_semaphore, session,post=True):
140149

141150
if post:
142151
try:
143-
async with session.post(API_POLLER_POST_URI, json=data) as res:
152+
async with session.post(
153+
API_POLLER_POST_URI, json=data
154+
) as res:
144155
if res.status == 200:
145-
log_message = f"Successfully polled and posted data for {hostname}"
156+
log_message = (
157+
f"Successfully polled and posted data "
158+
f"for {hostname}"
159+
)
146160
log.log2debug(1407, log_message)
147161
else:
148-
log_message = f"Failed to post data for {hostname}, status={res.status}"
162+
log_message = (
163+
f"Failed to post data for {hostname}, "
164+
f"status={res.status}"
165+
)
149166
log.log2warning(1414, log_message)
150167
except aiohttp.ClientError as e:
151-
log_message = f"HTTP error posting data for {hostname}: {e}"
168+
log_message = (
169+
f"HTTP error posting data for {hostname}: {e}"
170+
)
152171
log.log2exception(1415, log_message)
153172
return False
154173

@@ -157,7 +176,10 @@ async def device(poll_meta, device_semaphore, session,post=True):
157176

158177
return True
159178
else:
160-
log_message = f"Device {hostname} returns no data. Check connectivity/SNMP configuration"
179+
log_message = (
180+
f"Device {hostname} returns no data. Check "
181+
f"connectivity/SNMP configuration"
182+
)
161183
log.log2debug(1408, log_message)
162184
return False
163185

@@ -201,16 +223,20 @@ async def cli_device(hostname):
201223

202224
# Poll each zone occurrence
203225
semaphore = asyncio.Semaphore(1)
204-
tasks = [
205-
device(argument, semaphore, post=False)
206-
for argument in arguments
207-
]
208-
results = await asyncio.gather(*tasks, return_exceptions=True)
226+
async with aiohttp.ClientSession() as session:
227+
tasks = [
228+
device(argument, semaphore, session, post=False)
229+
for argument in arguments
230+
]
231+
results = await asyncio.gather(*tasks, return_exceptions=True)
209232

210233
# Check results
211234
success_count = sum(1 for r in results if r is True)
212235
if success_count > 0:
213-
log_message = f"Successfully polled {hostname} from {success_count}/{len(results)} zone(s)"
236+
log_message = (
237+
f"Successfully polled {hostname} from "
238+
f"{success_count}/{len(results)} zone(s)"
239+
)
214240
log.log2info(1411, log_message)
215241
else:
216242
log_message = f"Failed to poll {hostname} from any configured zone"

switchmap/poller/snmp/async_snmp_info.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ async def misc(self):
7676
vendor = iana_enterprise.Query(sysobjectid=sysobjectid)
7777
data["IANAEnterpriseNumber"] = vendor.enterprise()
7878
else:
79-
data["IANAEnterpriseNumber"] = None
80-
79+
data["IANAEnterpriseNumber"] = None
80+
8181
return data
8282

8383
async def system(self):

0 commit comments

Comments
 (0)