Skip to content

Commit 6ac435b

Browse files
authored
Update pull-request-target.yml
1 parent 92443bb commit 6ac435b

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

.github/workflows/pull-request-target.yml

+12-9
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,20 @@ jobs:
2525
message: |
2626
## Our Pull Request Approval Process
2727
28-
We have these basic policies to make the approval process smoother for our volunteer team.
28+
Thanks for contributing!
2929
3030
### Testing Your Code
31-
32-
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
33-
34-
1. The overall code coverage drops below the target threshold of the repository
35-
2. Any file in the pull request has code coverage levels below the repository threshold
36-
3. Merge conflicts
37-
38-
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
31+
32+
Remember, your PRs won't be reviewed until these criteria are met:
33+
34+
1. We don't merge PRs with poor code quality.
35+
1. Follow coding best practices such that CodeRabbit.ai approves your PR.
36+
1. We don't merge PRs with failed tests.
37+
1. When tests fail, click on the `Details` link to learn more.
38+
1. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
39+
1. Tests may fail if you edit sensitive files. Ask to add the `sensitive-files-ignore-pr` label if the edits are necessary.
40+
41+
These policies make our code better.
3942
4043
### Reviewers
4144

0 commit comments

Comments
 (0)