Skip to content

Commit

Permalink
Merge branch 'develop' into issue#2270
Browse files Browse the repository at this point in the history
  • Loading branch information
Suyash878 authored Nov 26, 2024
2 parents b7fbd06 + 832d310 commit bd04520
Show file tree
Hide file tree
Showing 4 changed files with 709 additions and 28 deletions.
22 changes: 13 additions & 9 deletions .github/workflows/pull-request-target.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,21 @@ jobs:
message: |
## Our Pull Request Approval Process
We have these basic policies to make the approval process smoother for our volunteer team.
Thanks for contributing!
### Testing Your Code
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Remember, your PRs won't be reviewed until these criteria are met:
1. We don't merge PRs with poor code quality.
1. Follow coding best practices such that CodeRabbit.ai approves your PR.
1. We don't merge PRs with failed tests.
1. When tests fail, click on the `Details` link to learn more.
1. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
1. Tests may fail if you edit sensitive files. Ask to add the `ignore-sensitive-files-pr` label if the edits are necessary.
1. We cannot merge PRs with conflicting files. These must be fixed.
Our policies make our code better.
### Reviewers
Expand Down
5 changes: 4 additions & 1 deletion INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ This document provides instructions on how to set up and start a running instanc
- [Install Required Packages](#install-required-packages)
- [Installation Using Docker](#installation-using-docker)
- [Run the Talawa-API Setup](#run-the-talawa-api-setup)
- [Install Using Devpod](#install-using-devpod)
- [Setting Up Talawa-Api with Devpod (CLI Version)](#setting-up-talawa-api-with-devpod-cli-version)
- [Setting Up Talawa-Api with Devpod (GUI Version)](#setting-up-talawa-api-with-devpod-gui-version)
- [Install the Docker Application](#install-the-docker-application)
- [Docker Compose Setup](#docker-compose-setup)
- [Prerequisites](#prerequisites-1)
Expand Down Expand Up @@ -1283,4 +1286,4 @@ You can run the tests for talawa-api using this command:
```
npm run test
```
```
Loading

0 comments on commit bd04520

Please sign in to comment.