What doesn't work/I couldn't/didn't know how to merge/fix

[Panchovix]

Hi there guys, hope is all is going good for you.

I decided after some time not having updates on Forge (~5 months), I felt it was missing important or small updates from A1111, that I should update it so it is more usable and more with the times if it's needed.

So I went, commit by commit from 5 months ago, up to today's updates of the dev branch of A1111 (https://github.com/AUTOMATIC1111/stable-diffusion-webui/commits/dev) and updated the code, manually, from the dev2 branch of forge (https://github.com/lllyasviel/stable-diffusion-webui-forge/commits/dev2) to see which could be merged or not, and which conflicts as well.

​
For now, this is the list of features (probably more) that doesn't work/I couldn't/didn't know how to merge/fix:

• Soft Inpainting (I had to edit sd_samplers_cfg_denoiser.py to apply some A1111 changes, so I couldn't directly apply Temp fix to make soft inpainting work lllyasviel/stable-diffusion-webui-forge#494) EDIT: For now it seems that soft inpainting is enabled by default, and when checking the option it does another (unkown) thing.
  EDIT2: Maybe fixed in 101af34
  Fixed
• SD3 (Since forge has it's own unet implementation, I didn't tinker on implementing it). Any help to implement this would be really appreciated!
• Callback order (AUTOMATIC1111/stable-diffusion-webui@5bd2724), specifically because the forge implementation of modules doesn't have script_callbacks. So it broke the included controlnet extension and ui_settings.py.
• Didn't tinker much about changes that affect extensions-builtin\Lora, since forge does it mostly on ldm_patched\modules. But some of them could be applied thay I have may skipped.
• precision-half (forge has this by default)
• New "is_sdxl" flag (sdxl works fine, but there are some new things that don't work without this flag)
• DDIM CFG++ (because the edit on sd_samplers_cfg_denoiser.py). Researching on how to modify sd_samplers_cfg_denoiser.py to make it work. EDIT: In the progress to make it work.
• 7f8f332 (NGMI, s_churn, etc is not updated atm because these changed that were needed) Fixed
• Newer controlnet updates into the built-in extension.

The list (but not all) I couldn't/didn't know how to merge/fix is here: https://pastebin.com/sMCfqBua

Any help trying or attempting for the implementation of those is really appreciated!

[michP247]

thanks for the hard work, also is batch controlnet supposed to be working now? It still only processes the first image in the specified folder like it used to on main Forge. Maybe I'm doing something wrong though

[Panchovix]

thanks for the hard work, also is batch controlnet supposed to be working now? It still only processes the first image in the specified folder like it used to on main Forge. Maybe I'm doing something wrong though

I haven't touched the integrated controlnet extension for forge at the moment, so probably it works as the same from there. I'm thinking on making just normal controlnet work with forge or seeing how to update the extension to controlnet upstream, but haven't decided yet. It will probably take a while since I haven't seen any of the code of the controlnets extension yet.

EDIT: Checking any of these options is very hard, so any help will be appreciated since either redirect normal controlnet to forge or updating the in built extension is really, really hard. Really sorry for the ping @huchenlei, but is there a way I can contact you to see this?

Thanks for the info though, gonna add it into the post.

[StarComrade]

Would it be possible to revert the Lora preview Tree View to be on the side like it was on the old Forge? Having it on top obscures 80% of the screen and is counterintuitive to the actual previewing.

[Panchovix]

Would it be possible to revert the Lora preview Tree View to be on the side like it was on the old Forge? Having it on top obscures 80% of the screen and is counterintuitive to the actual previewing.

Can you open a new issue with some images please? So I can check what's happening and how I could fix it.