Adventure 5.0 #1253
Open
Adventure 5.0 #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures Also adds a missing `PlatformAPI` annotation and removes an unused method in CallerClassFinder.
…tions and use modern language features
…recations and use modern language features
kashike
reviewed
Oct 10, 2025
Fixes an error when building.
Also revert build-logic project to J17, to align with Gradle's minimum.
chore: fix remaining tests
Optional NBT payload for custom click events
…monorepo chore(deps): Update dependency org.junit:junit-bom to v6
chore(deps): Update dependency com.puppycrawl.tools:checkstyle to v12
chore(deps): Update guava monorepo to v33.5.0-jre
This should allow subtypes of ProfileProperty, which is commonly used by the implementing platform, to return a different type that may contain more information. This is not an ABI break.
fix(api): Unbound profileProperties Collection
feature(api): Add BookLike interface
Platforms can implement this with actual signed messages (not just system ones), so it needs to be unsealed.
Resource bundles are UTF-8 by default since Java 9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR exists to track the progress on Adventure 5.0. It only exists as a PR for review purposes, once Adventure 5.0 is complete, the main branch of the repo will be changed to
main/5.Discussion in this PR will be limited to reviews of the PR itself. For discussion about broader changes in Adventure 5.0, please see #1202.
To-do list:
The list below tracks remaining tasks. For reference, "refactor" means removal of all deprecations and refactoring of code to use modern Java language features.
annotation-processorsmodule.apimodule.extra-kotlinmodule.keymodule.nbtmodule.serializer-configurate-4module.text-logger-slf4jmodule.text-minimessagemodule.text-serializer-ansimodule.text-serializer-commonsmodule.text-serializer-gsonmodule.text-serializer-gson-legacy-implmodule.text-serializer-jsonmodule.text-serializer-json-legacymodule.text-serializer-legacymodule.text-serializer-plainmodule.TextFormatsealed.data, SBA...4.0 changes required
Deprecate:
Add
ApiStatus.NonExtendibleto:Remaining discussion points
i dont think so, doesn't seem like mc is bumping any time soon?
atm it's literally just used for toString, but is sometimes in the API classes and sometimes impl only - we should be consistent here
data,data, style,data, sba...? yes, with old methods left as synthetic