review feedback

Author: VeckoTheGecko

parcels/_index_search.py

@@ -190,7 +190,6 @@ def _search_indices_rectilinear(
 
     if grid.zdim > 1 and not search2D:
         if grid._gtype == GridType.RectilinearZGrid:
-            # Never passes here, because in this case, we work with scipy
             try:
                 (zi, zeta) = search_indices_vertical_z(field.grid, field.gridindexingtype, z)
             except FieldOutOfBoundError:

parcels/_interpolation.py

@@ -128,8 +128,7 @@ def _interp_on_unit_square(*, eta: float, xsi: float, data: np.ndarray, yi: int,
 @register_2d_interpolator("partialslip")
 @register_2d_interpolator("freeslip")
 def _linear_2d(ctx: InterpolationContext2D) -> float:
-    val = _interp_on_unit_square(eta=ctx.eta, xsi=ctx.xsi, data=ctx.data[ctx.ti, :, :], yi=ctx.yi, xi=ctx.xi)
-    return val
+    return _interp_on_unit_square(eta=ctx.eta, xsi=ctx.xsi, data=ctx.data[ctx.ti, :, :], yi=ctx.yi, xi=ctx.xi)
 
 
 @register_2d_interpolator("linear_invdist_land_tracer")
@@ -161,8 +160,7 @@ def _linear_invdist_land_tracer_2d(ctx: InterpolationContext2D) -> float:
                     w_sum += 1 / distance
         return val / w_sum
     else:
-        val = _interp_on_unit_square(eta=eta, xsi=xsi, data=data[ti, :, :], yi=yi, xi=xi)
-        return val
+        return _interp_on_unit_square(eta=eta, xsi=xsi, data=data[ti, :, :], yi=yi, xi=xi)
 
 
 @register_2d_interpolator("cgrid_tracer")

parcels/field.py

@@ -1004,7 +1004,7 @@ def interpolator2D(self, *_):
         raise NotImplementedError
 
     def _interpolator2D(self, ti, z, y, x, particle=None):
-        """Impelement 2D interpolation with coordinate transformations as seen in Delandmeter, P. and van Sebille, E (2019)."""
+        """Impelement 2D interpolation with coordinate transformations as seen in Delandmeter and Van Sebille (2019), 10.5194/gmd-12-3571-2019.."""
         (_, eta, xsi, _, yi, xi) = self._search_indices(-1, z, y, x, particle=particle)
         ctx = InterpolationContext2D(self.data, eta, xsi, ti, yi, xi)
 
@@ -1024,7 +1024,7 @@ def interpolator3D(self, *_):
         raise NotImplementedError
 
     def _interpolator3D(self, ti, z, y, x, time, particle=None):
-        """Impelement 3D interpolation with coordinate transformations as seen in Delandmeter, P. and van Sebille, E (2019)."""
+        """Impelement 3D interpolation with coordinate transformations as seen in Delandmeter and Van Sebille (2019), 10.5194/gmd-12-3571-2019.."""
         (zeta, eta, xsi, zi, yi, xi) = self._search_indices(time, z, y, x, ti, particle=particle)
         ctx = InterpolationContext3D(self.data, zeta, eta, xsi, ti, zi, yi, xi, self.gridindexingtype)