Skip to content

Commit 58235ab

Browse files
committed
Review feedback
1 parent 69e3759 commit 58235ab

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

parcels/particle.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def get_default_particle(spatial_dtype: np.float32 | np.float64) -> ParticleClas
171171
Variable("time_nextloop", dtype=_SAME_AS_FIELDSET_TIME_INTERVAL.VALUE, to_write=False),
172172
Variable("id", dtype=np.int64, to_write="once"),
173173
Variable("obs_written", dtype=np.int32, initial=0, to_write=False),
174-
Variable("dt", dtype="timedelta64[ns]", initial=np.timedelta64(1, "ns"), to_write=False),
174+
Variable("dt", dtype="timedelta64[s]", initial=np.timedelta64(1, "s"), to_write=False),
175175
Variable("state", dtype=np.int32, initial=StatusCode.Evaluate, to_write=False),
176176
]
177177
)

parcels/particlefile.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,6 @@ def write_latest_locations(self, pset, time):
306306
def _get_store_from_pathlike(path: Path | str) -> LocalStore:
307307
path = str(Path(path)) # Ensure valid path, and convert to string
308308
extension = os.path.splitext(path)[1]
309-
if extension in [".nc", ".nc4"]:
310-
raise ValueError("Output in NetCDF is not supported anymore. Use .zarr extension for ParticleFile name.")
311309
if extension != ".zarr":
312310
raise ValueError(f"ParticleFile name must end with '.zarr' extension. Got path {path!r}.")
313311

0 commit comments

Comments
 (0)