Remove convert_xarray_time_units (see #1919)

Author: VeckoTheGecko

parcels/fieldfilebuffer.py

@@ -6,7 +6,6 @@
 import xarray as xr
 
 from parcels._typing import InterpMethodOption, PathLike
-from parcels.tools.converters import convert_xarray_time_units
 from parcels.tools.warnings import FileWarning
 
 
@@ -148,7 +147,6 @@ def time_access(self):
             return np.array([None])
 
         time_da = self.dataset[self.dimensions["time"]]
-        convert_xarray_time_units(time_da, self.dimensions["time"])
         time = (
             np.array([time_da[self.dimensions["time"]].data])
             if len(time_da.shape) == 0

parcels/fieldset.py

@@ -14,7 +14,7 @@
 from parcels.gridset import GridSet
 from parcels.particlefile import ParticleFile
 from parcels.tools._helpers import fieldset_repr
-from parcels.tools.converters import TimeConverter, convert_xarray_time_units
+from parcels.tools.converters import TimeConverter
 from parcels.tools.loggers import logger
 from parcels.tools.warnings import FieldSetWarning
 
@@ -1162,10 +1162,6 @@ def from_xarray_dataset(cls, ds, variables, dimensions, mesh="spherical", allow_
         fields = {}
         if "creation_log" not in kwargs.keys():
             kwargs["creation_log"] = "from_xarray_dataset"
-        if "time" in dimensions:
-            if "units" not in ds[dimensions["time"]].attrs and "Unit" in ds[dimensions["time"]].attrs:
-                # Fix DataArrays that have time.Unit instead of expected time.units
-                convert_xarray_time_units(ds, dimensions["time"])
 
         for var, name in variables.items():
             dims = dimensions[var] if var in dimensions else dimensions

parcels/tools/converters.py

@@ -7,7 +7,6 @@
 import cftime
 import numpy as np
 import numpy.typing as npt
-import xarray as xr
 
 __all__ = [
     "Geographic",
@@ -17,7 +16,6 @@
     "TimeConverter",
     "UnitConverter",
     "convert_to_flat_array",
-    "convert_xarray_time_units",
     "unitconverters_map",
 ]
 
@@ -235,16 +233,3 @@ def to_source(self, value, z, y, x):
     "Kh_zonal": GeographicPolarSquare(),
     "Kh_meridional": GeographicSquare(),
 }
-
-
-def convert_xarray_time_units(ds, time):
-    """Fixes DataArrays that have time.Unit instead of expected time.units"""
-    da = ds[time] if isinstance(ds, xr.Dataset) else ds
-    if "units" not in da.attrs and "Unit" in da.attrs:
-        da.attrs["units"] = da.attrs["Unit"]
-    da2 = xr.Dataset({time: da})
-    try:
-        da2 = xr.decode_cf(da2)
-    except ValueError:
-        raise RuntimeError("Xarray could not convert the calendar.")
-    ds[time] = da2[time]