Remove analytical output

Author: VeckoTheGecko

parcels/kernel.py

@@ -228,8 +228,6 @@ def check_fieldsets_in_kernels(self, pyfunc):  # TODO v4: this can go into anoth
                         stacklevel=2,
                     )
             elif pyfunc is AdvectionAnalytical:
-                if self.fieldset.particlefile is not None:
-                    self.fieldset.particlefile._is_analytical = True
                 if self._fieldset.U.interp_method != "cgrid_velocity":
                     raise NotImplementedError("Analytical Advection only works with C-grids")
                 if self._fieldset.U.grid._gtype not in [GridType.CurvilinearZGrid, GridType.RectilinearZGrid]:

parcels/particlefile.py

@@ -63,8 +63,6 @@ def __init__(self, name, particleset, outputdt, chunks=None, create_new_zarrfile
             if var.to_write:
                 self.vars_to_write[var.name] = var.dtype
         self._mpi_rank = MPI.COMM_WORLD.Get_rank() if MPI else 0
-        self.particleset.fieldset._particlefile = self
-        self._is_analytical = False  # Flag to indicate if ParticleFile is used for analytical trajectories
 
         # Reset obs_written of each particle, in case new ParticleFile created for a ParticleSet
         particleset.particledata.setallvardata("obs_written", 0)

parcels/particleset.py

@@ -1083,10 +1083,7 @@ def execute(
 
             if abs(time - next_output) < tol:
                 if output_file:
-                    if output_file._is_analytical:  # output analytical solution at later time
-                        output_file.write_latest_locations(self, time)
-                    else:
-                        output_file.write(self, time_at_startofloop)
+                    output_file.write(self, time_at_startofloop)
                 if np.isfinite(outputdt):
                     next_output += outputdt * np.sign(dt)