Review feedback

Author: VeckoTheGecko

parcels/particle.py

@@ -171,7 +171,7 @@ def get_default_particle(spatial_dtype: np.float32 | np.float64) -> ParticleClas
             Variable("time_nextloop", dtype=_SAME_AS_FIELDSET_TIME_INTERVAL.VALUE, to_write=False),
             Variable("id", dtype=np.int64, to_write="once"),
             Variable("obs_written", dtype=np.int32, initial=0, to_write=False),
-            Variable("dt", dtype="timedelta64[ns]", initial=np.timedelta64(1, "ns"), to_write=False),
+            Variable("dt", dtype="timedelta64[s]", initial=np.timedelta64(1, "s"), to_write=False),
             Variable("state", dtype=np.int32, initial=StatusCode.Evaluate, to_write=False),
         ]
     )

parcels/particlefile.py

@@ -306,8 +306,6 @@ def write_latest_locations(self, pset, time):
 def _get_store_from_pathlike(path: Path | str) -> LocalStore:
     path = str(Path(path))  # Ensure valid path, and convert to string
     extension = os.path.splitext(path)[1]
-    if extension in [".nc", ".nc4"]:
-        raise ValueError("Output in NetCDF is not supported anymore. Use .zarr extension for ParticleFile name.")
     if extension != ".zarr":
         raise ValueError(f"ParticleFile name must end with '.zarr' extension. Got path {path!r}.")
 

tests/v4/test_advection.py

@@ -84,7 +84,7 @@ def test_horizontal_advection_in_3D_flow(npart=10):
     pset.execute(AdvectionRK4, runtime=np.timedelta64(2, "h"), dt=np.timedelta64(15, "m"))
 
     expected_lon = pset.depth * (pset.time - fieldset.time_interval.left) / np.timedelta64(1, "s")
-    np.testing.assert_allclose(expected_lon, pset.lon, atol=1.0e-1)
+    np.testing.assert_allclose(pset.lon, expected_lon, atol=1.0e-1)
 
 
 @pytest.mark.parametrize("direction", ["up", "down"])