Skip to content

Commit 990e1ac

Browse files
committed
Mark failing tests
test_kernel_warnings and test_globcurrent_startparticles_between_time_arrays
1 parent c37416c commit 990e1ac

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

docs/examples/example_globcurrent.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,9 +211,19 @@ def test_globcurrent_time_extrapolation_error(use_xarray):
211211
)
212212

213213

214+
@pytest.mark.v4alpha
215+
@pytest.mark.xfail(
216+
reason="This was always broken when using eager loading `deferred_load=False` for the P field. Needs to be fixed."
217+
)
214218
@pytest.mark.parametrize("dt", [-300, 300])
215219
@pytest.mark.parametrize("with_starttime", [True, False])
216220
def test_globcurrent_startparticles_between_time_arrays(dt, with_starttime):
221+
"""Test for correctly initialising particle start times.
222+
223+
When using Fields with different temporal domains, its important to intialise particles
224+
at the beginning of the time period where all Fields have available data (i.e., the
225+
intersection of the temporal domains)
226+
"""
217227
fieldset = set_globcurrent_fieldset()
218228

219229
data_folder = parcels.download_example_dataset("GlobCurrent_example_data")

tests/tools/test_warnings.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ def test_file_warnings(tmp_zarrfile):
4848
pset.execute(AdvectionRK4, runtime=3, dt=1, output_file=pfile)
4949

5050

51+
@pytest.mark.v4alpha
52+
@pytest.mark.xfail(reason="https://github.com/OceanParcels/Parcels/pull/1908#issuecomment-2698014941")
5153
def test_kernel_warnings():
5254
# positive scaling factor for W
5355
filenames = str(TEST_DATA / "POPtestdata_time.nc")

0 commit comments

Comments
 (0)