Skip to content

Commit ba29efb

Browse files
Merge branch 'v4-dev' into remove_fieldset_from_pop
2 parents de2986a + 2d21efa commit ba29efb

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ jobs:
9797
needs:
9898
- unit-test
9999
- integration-test
100+
- typechecking
100101
steps:
101102
- name: Merge Artifacts
102103
uses: actions/upload-artifact/merge@v4
@@ -116,13 +117,10 @@ jobs:
116117
- run: conda install lxml # dep for report generation
117118
- name: Typechecking
118119
run: |
119-
mypy --install-types --non-interactive parcels --cobertura-xml-report mypy_report
120-
- name: Upload mypy coverage to Codecov
121-
uses: codecov/[email protected]
122-
if: ${{ always() }} # Upload even on error of mypy
123-
env:
124-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
120+
mypy --install-types --non-interactive parcels --html-report mypy-report
121+
- name: Upload test results
122+
if: ${{ always() }} # Upload even on mypy error
123+
uses: actions/upload-artifact@v4
125124
with:
126-
file: mypy_report/cobertura.xml
127-
flags: mypy
128-
fail_ci_if_error: false
125+
name: Mypy report
126+
path: mypy-report

environment.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ dependencies: #! Keep in sync with [tool.pixi.dependencies] in pyproject.toml
3030

3131
# Typing
3232
- mypy
33+
- lxml # in CI
3334
- types-tqdm
3435
- types-psutil
3536

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ coverage = "*"
8585

8686
# Typing
8787
mypy = "*"
88+
lxml = "*" # in CI
8889
types-tqdm = "*"
8990
types-psutil = "*"
9091

0 commit comments

Comments
 (0)