Review feedback

VeckoTheGecko · VeckoTheGecko · commit bfb1f624696f · 2025-02-27T17:07:04.000+01:00
diff --git a/docs/examples/example_mitgcm.py b/docs/examples/example_mitgcm.py
@@ -41,6 +41,7 @@ def periodicBC(particle, fieldset, time):  # pragma: no cover
         str(path),
         pset,
         outputdt=timedelta(days=1),
+        chunks=(len(pset), 1),
     )
     kernels = parcels.AdvectionRK4 + pset.Kernel(periodicBC)
     pset.execute(
diff --git a/parcels/_typing.py b/parcels/_typing.py
@@ -28,7 +28,6 @@
 PathLike = str | os.PathLike
 Mesh = Literal["spherical", "flat"]  # corresponds with `mesh`
 VectorType = Literal["3D", "3DSigma", "2D"] | None  # corresponds with `vector_type`
-ChunkMode = Literal["auto", "specific", "failsafe"]  # corresponds with `chunk_mode`
 GridIndexingType = Literal["pop", "mom5", "mitgcm", "nemo", "croco"]  # corresponds with `gridindexingtype`
 UpdateStatus = Literal["not_updated", "first_updated", "updated"]  # corresponds with `_update_status`
 NetcdfEngine = Literal["netcdf4", "xarray", "scipy"]

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ def periodicBC(particle, fieldset, time): # pragma: no cover`
`41`	`41`	`str(path),`
`42`	`42`	`pset,`
`43`	`43`	`outputdt=timedelta(days=1),`
	`44`	`+ chunks=(len(pset), 1),`
`44`	`45`	`)`
`45`	`46`	`kernels = parcels.AdvectionRK4 + pset.Kernel(periodicBC)`
`46`	`47`	`pset.execute(`