Skip to content

Commit fc71177

Browse files
Testing different Advection Kernels
Note that AdvectionRK45 doesn't work (fix in #2397)
1 parent 4b62e92 commit fc71177

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tests/test_particleset_execute.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from parcels._datasets.structured.generic import datasets as datasets_structured
2424
from parcels._datasets.unstructured.generic import datasets as datasets_unstructured
2525
from parcels.interpolators import UXPiecewiseConstantFace, UXPiecewiseLinearNode, XLinear
26-
from parcels.kernels import AdvectionEE, AdvectionRK4, AdvectionRK4_3D
26+
from parcels.kernels import AdvectionEE, AdvectionRK2, AdvectionRK4, AdvectionRK4_3D, AdvectionRK45
2727
from tests.common_kernels import DoNothing
2828

2929

@@ -162,7 +162,8 @@ def SampleU(particles, fieldset): # pragma: no cover
162162
assert pset[0].time == endtime
163163

164164

165-
def test_particleset_run_RK_to_endtime_fwd_bwd(fieldset):
165+
@pytest.mark.parametrize("kernel", [AdvectionEE, AdvectionRK2, AdvectionRK4, AdvectionRK45])
166+
def test_particleset_run_RK_to_endtime_fwd_bwd(fieldset, kernel):
166167
"""Test that RK kernels can be run to the endtime of a fieldset (and not throw OutsideTimeInterval)"""
167168
starttime = fieldset.time_interval.left
168169
endtime = fieldset.time_interval.right
@@ -173,10 +174,10 @@ def test_particleset_run_RK_to_endtime_fwd_bwd(fieldset):
173174
fieldset.V.data[:] = 0.0
174175

175176
pset = ParticleSet(fieldset, lon=[0.2], lat=[5.0], time=[starttime])
176-
pset.execute(AdvectionRK4, endtime=endtime, dt=dt)
177+
pset.execute(kernel, endtime=endtime, dt=dt)
177178
assert pset[0].time == endtime
178179

179-
pset.execute(AdvectionRK4, endtime=starttime, dt=-dt)
180+
pset.execute(kernel, endtime=starttime, dt=-dt)
180181
assert pset[0].time == starttime
181182

182183

0 commit comments

Comments
 (0)