diff --git a/docs/conf.py b/docs/conf.py index 00f2a180..15f8ee9f 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -14,7 +14,7 @@ "sphinx.ext.intersphinx", "sphinx.ext.mathjax", "sphinx.ext.napoleon", - "sphinx_autodoc_typehints", + # "sphinx_autodoc_typehints",# https://github.com/OceanParcels/virtualship/pull/125#issuecomment-2668766302 "sphinx_copybutton", ] diff --git a/docs/user-guide/tutorials/Drifter_data_tutorial.ipynb b/docs/user-guide/tutorials/Drifter_data_tutorial.ipynb index 6aa055e4..41c62bfa 100755 --- a/docs/user-guide/tutorials/Drifter_data_tutorial.ipynb +++ b/docs/user-guide/tutorials/Drifter_data_tutorial.ipynb @@ -62,7 +62,7 @@ "outputs": [], "source": [ "expedition_directory = Path(\"/Users/erik/Desktop/VSC_AgulhasDrifters\")\n", - "fieldset = InputData._load_default_fieldset(expedition_directory)" + "fieldset = InputData._load_ship_fieldset(expedition_directory)" ] }, { diff --git a/environment.yml b/environment.yml index 42319ad6..38d96dc3 100644 --- a/environment.yml +++ b/environment.yml @@ -31,6 +31,6 @@ dependencies: - ipykernel - pandoc - sphinx-copybutton - - sphinx-autodoc-typehints + # - sphinx-autodoc-typehints # https://github.com/OceanParcels/virtualship/pull/125#issuecomment-2668766302 - pydata-sphinx-theme - sphinx-autobuild diff --git a/src/virtualship/cli/commands.py b/src/virtualship/cli/commands.py index 2446e1f9..2909c72e 100644 --- a/src/virtualship/cli/commands.py +++ b/src/virtualship/cli/commands.py @@ -155,17 +155,17 @@ def fetch(path: str | Path, username: str | None, password: str | None) -> None: "UVdata": { "dataset_id": "cmems_mod_glo_phy-cur_anfc_0.083deg_PT6H-i", "variables": ["uo", "vo"], - "output_filename": "default_uv.nc", + "output_filename": "ship_uv.nc", }, "Sdata": { "dataset_id": "cmems_mod_glo_phy-so_anfc_0.083deg_PT6H-i", "variables": ["so"], - "output_filename": "default_s.nc", + "output_filename": "ship_s.nc", }, "Tdata": { "dataset_id": "cmems_mod_glo_phy-thetao_anfc_0.083deg_PT6H-i", "variables": ["thetao"], - "output_filename": "default_t.nc", + "output_filename": "ship_t.nc", }, } diff --git a/src/virtualship/expedition/input_data.py b/src/virtualship/expedition/input_data.py index 712b1e1a..554efb78 100644 --- a/src/virtualship/expedition/input_data.py +++ b/src/virtualship/expedition/input_data.py @@ -52,21 +52,21 @@ def load( else: argo_float_fieldset = None if load_adcp or load_ctd or load_ship_underwater_st or load_xbt: - default_fieldset = cls._load_default_fieldset(directory) + ship_fieldset = cls._load_ship_fieldset(directory) if load_adcp: - adcp_fieldset = default_fieldset + adcp_fieldset = ship_fieldset else: adcp_fieldset = None if load_ctd: - ctd_fieldset = default_fieldset + ctd_fieldset = ship_fieldset else: ctd_fieldset = None if load_ship_underwater_st: - ship_underwater_st_fieldset = default_fieldset + ship_underwater_st_fieldset = ship_fieldset else: ship_underwater_st_fieldset = None if load_xbt: - xbt_fieldset = default_fieldset + xbt_fieldset = ship_fieldset else: xbt_fieldset = None @@ -80,12 +80,12 @@ def load( ) @classmethod - def _load_default_fieldset(cls, directory: Path) -> FieldSet: + def _load_ship_fieldset(cls, directory: Path) -> FieldSet: filenames = { - "U": directory.joinpath("default_uv.nc"), - "V": directory.joinpath("default_uv.nc"), - "S": directory.joinpath("default_s.nc"), - "T": directory.joinpath("default_t.nc"), + "U": directory.joinpath("ship_uv.nc"), + "V": directory.joinpath("ship_uv.nc"), + "S": directory.joinpath("ship_s.nc"), + "T": directory.joinpath("ship_t.nc"), } variables = {"U": "uo", "V": "vo", "S": "so", "T": "thetao"} dimensions = { diff --git a/tests/expedition/expedition_dir/input_data/.gitignore b/tests/expedition/expedition_dir/input_data/.gitignore index 0f4bf3bf..2235154f 100644 --- a/tests/expedition/expedition_dir/input_data/.gitignore +++ b/tests/expedition/expedition_dir/input_data/.gitignore @@ -2,8 +2,8 @@ !argo_float_t.nc !argo_float_uv.nc !bathymetry.nc -!default_s.nc -!default_t.nc -!default_uv.nc +!ship_s.nc +!ship_t.nc +!ship_uv.nc !drifter_t.nc !drifter_uv.nc diff --git a/tests/expedition/expedition_dir/input_data/default_s.nc b/tests/expedition/expedition_dir/input_data/ship_s.nc similarity index 100% rename from tests/expedition/expedition_dir/input_data/default_s.nc rename to tests/expedition/expedition_dir/input_data/ship_s.nc diff --git a/tests/expedition/expedition_dir/input_data/default_t.nc b/tests/expedition/expedition_dir/input_data/ship_t.nc similarity index 100% rename from tests/expedition/expedition_dir/input_data/default_t.nc rename to tests/expedition/expedition_dir/input_data/ship_t.nc diff --git a/tests/expedition/expedition_dir/input_data/default_uv.nc b/tests/expedition/expedition_dir/input_data/ship_uv.nc similarity index 100% rename from tests/expedition/expedition_dir/input_data/default_uv.nc rename to tests/expedition/expedition_dir/input_data/ship_uv.nc