Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: migrate scaffolder plugins to Backstage repo #30

Open
antoniobergas opened this issue Sep 26, 2023 · 19 comments
Open

RFC: migrate scaffolder plugins to Backstage repo #30

antoniobergas opened this issue Sep 26, 2023 · 19 comments

Comments

@antoniobergas
Copy link
Contributor

As more and more people is using Backstage and by that all Azure DevOps users are using this scaffolder plugins I want to suggest to migrate them to the Backstage repo.

AFAIK Backstage maintainers already recommend officially this plugins in the documentation, so would make sense to move them so the community can take ownership to keep them update?

What you think?

@MatthiasKainer
@hevans-dglcom
@clemensheithecker

@antoniobergas
Copy link
Contributor Author

A few days ago, one of the key contributors to Backstage brought an interesting RFC from the Backstage repository to my attention. You can find it here: backstage/backstage#20266

Currently, there is an ongoing discussion regarding the best solution, but in the interim, it would be highly beneficial to find a way to update both the azure-devops-scaffolder plugins.

If the proposed move outlined in this RFC is contingent on approval within the Backstage RFC, I'd like to suggest two possible approaches:

Grant commit and PR approval permissions to someone who can assist in updating the plugins. I'm more than willing to take on this responsibility if you're comfortable with it.

If, for any reason, you're unable or unwilling to provide these permissions, would it be feasible to consider forking the repository and publishing it as an @backstage package?

I appreciate your consideration and look forward to hearing from you! 😁

@antoniobergas
Copy link
Contributor Author

Hey there!

I've noticed more and more folks are running into issues with this problem. I really want to find a solution that can help everyone out.

I'm up for creating a fork and trying to fix it. If I manage to fix it, I'll publish it under the "@backstage" name.

Down the road, when you've got some time, we can chat about merging these fixes and discuss what steps you'd like to take next.

I hope you understand how important it is to take action. Thanks a bunch!

@antoniobergas
Copy link
Contributor Author

antoniobergas commented Oct 13, 2023

Hi! I created 2 temporary npm packages with the fixes!

Repositories plugin package

Pipeline plugin package

I just did a quick fix until we hear from the owners, be aware that could be done better 😅 But looks like its working good! You can find the README.md with the updated changes you must do .

At the end I just published under my personal because 2 reasons:

  • Bring the temp solution faster
  • Cause it is unclear if should be move to @backstage

I tested only on Azure DevOps Server, but as far as I understood the code, it should be working equal for dev.azure.com

I will address any issues related to the fixes I've made, but until we receive updates on this situation, I won't be able to handle any other matters at this time. Thank you for your understanding.

I understand that there might be distrust about this changes so I courage you to take a look to my forked repos so you can see the all the changes before use the packages:

Pipelines plugin forked repo

Repositories plugin forked repo

In addition I share some links from the official Backstage Discord conversation with one of the main contributors for the azdops stack and the RFC related from the official Backstage repo:

Azure DevOps issue on Discord

Related RFC in Backstage repo

I hope this can help to keep updating Backstage until we find a proper solution.

Cheers!

@cr0wnf0x
Copy link
Contributor

@antoniobergas I'm sorry for the very late answer and for leaving the community in the air with their issues. I'll take your suggestion for an internal discussion and will get back to you tomorrow about moving the plugins to the official backstage repo and having it maintained by the community.

Cheers

@ZOBHeile
Copy link

@cr0wnf0x @antoniobergas Hi is there any update on the progress?

@antoniobergas
Copy link
Contributor Author

Hi @ZOBHeile I have no update yet, maybe the maintainers can shed some light on the matter 🙏

@antoniobergas
Copy link
Contributor Author

antoniobergas commented Jan 15, 2024

Hi guys!

Is there any news on this? Will appreciate a response to keep this plugins updated for the community, thank you!

@cr0wnf0x

@jmezach
Copy link

jmezach commented Jan 24, 2024

Looks like the Backstage team has decided to move forward with a community plugins repo. See backstage/backstage#20266 (comment). Unfortunately they haven't set this up yet. Would appreciate an update on the status here though. We're keen to use these plugins, but are hesitant due to the lack of support.

@Tushti02
Copy link

@cr0wnf0x do we have any update on this as createAzurePipelineAction now fails with latest version upgrade of "@backstage/integration": "^1.6.2"

@jmezach
Copy link

jmezach commented Feb 1, 2024

Note that the Backstage team has started a discussion around a community owned plugins repo. See backstage/community#120 for more details.

@DanielPerezJensen
Copy link

@antoniobergas thanks for your fixes that you have made, was going mad trying to fix it myself.

Would suggest the maintainers to really look at this, current scaffolder does not work without Antonios fixes.

@Phiph
Copy link

Phiph commented Jul 22, 2024

Hey @antoniobergas @cr0wnf0x.

I'm blocked by this and I am considering moving the plugins to the community repo, what should we do about the copyright notice? Should it be the original authors - or are you happy for it to be the same pattern in backstage community repo?

@antoniobergas
Copy link
Contributor Author

antoniobergas commented Jul 22, 2024

Hi @Phiph ,

I can't provide information about the copyright since I'm not one of the maintainers of this repository. However, I support moving it as I initially suggested in the original issue.

If I may ask, why are you blocked by this? Have you tested my temporary packages?

@Phiph
Copy link

Phiph commented Jul 24, 2024

Ahhh good point I always get mixed up between the 2 packages, I'll try yours out again :) Thanks!

Does that mean we're kinda blocked on copyright if we moved the code to backstage community?

@antoniobergas
Copy link
Contributor Author

Not sure about what can be done with this copyrigh but anyways I think the actual code its just http calls with fetch and maybe a rework using the azure devops node api would be great 😁

@Phiph
Copy link

Phiph commented Jul 25, 2024

I've tried integrating your packages into backstage, however it looks like the new backend is providing the Type 'ScmIntegrations' and is not assignable to type 'ScmIntegrationRegistry'.

I'll try and pick the action to make into backstage community soon.

@antoniobergas
Copy link
Contributor Author

The packages are not compatible with the new backend system, you need to load them as legacyPlugin

@awanlin
Copy link

awanlin commented Sep 28, 2024

Hi, just wanted to share this Issue I logged in the Backstage Community Plugins repo: backstage/community-plugins#1393. Would very much like to get feedback from the maintainers of this repo before moving forward.

@awanlin
Copy link

awanlin commented Oct 8, 2024

Hi, just following up as I have not heard back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants