diff --git a/example/src/main/java/com/example/MainActivity.java b/example/src/main/java/com/example/MainActivity.java index b349d22a..6fff5e6c 100644 --- a/example/src/main/java/com/example/MainActivity.java +++ b/example/src/main/java/com/example/MainActivity.java @@ -116,7 +116,7 @@ public void trackPlay(View view) { new ArrayList(), "http://example.com/thumbs/video-1234", "Awesome Video #1234", - System.currentTimeMillis(), + Calendar.getInstance(), 90 ); // NOTE: For videos embedded in an article, "url" should be the URL for that article. diff --git a/parsely/src/main/java/com/parsely/parselyandroid/ParselyMetadata.kt b/parsely/src/main/java/com/parsely/parselyandroid/ParselyMetadata.kt index 9c43ee07..201b4eb5 100644 --- a/parsely/src/main/java/com/parsely/parselyandroid/ParselyMetadata.kt +++ b/parsely/src/main/java/com/parsely/parselyandroid/ParselyMetadata.kt @@ -1,5 +1,7 @@ package com.parsely.parselyandroid +import java.util.Calendar + /** * Represents post metadata to be passed to Parsely tracking. * @@ -19,7 +21,7 @@ open class ParselyMetadata * @param tags User-defined tags for the content. Up to 20 are allowed. * @param thumbUrl URL at which the main image for this content is located. * @param title The title of the content. - * @param publicationDateMilliseconds The date this piece of content was published. + * @param pubDate The date this piece of content was published. */( private val authors: List? = null, @JvmField internal val link: String? = null, @@ -27,7 +29,7 @@ open class ParselyMetadata private val tags: List? = null, private val thumbUrl: String? = null, private val title: String? = null, - private val publicationDateMilliseconds: Long? = null + private val pubDate: Calendar? = null ) { /** * Turn this object into a Map @@ -54,8 +56,8 @@ open class ParselyMetadata if (title != null) { output["title"] = title } - if (publicationDateMilliseconds != null) { - output["pub_date_tmsp"] = publicationDateMilliseconds / 1000 + if (pubDate != null) { + output["pub_date_tmsp"] = pubDate.timeInMillis / 1000 } return output } diff --git a/parsely/src/main/java/com/parsely/parselyandroid/ParselyVideoMetadata.kt b/parsely/src/main/java/com/parsely/parselyandroid/ParselyVideoMetadata.kt index 7d4857e6..4a877e31 100644 --- a/parsely/src/main/java/com/parsely/parselyandroid/ParselyVideoMetadata.kt +++ b/parsely/src/main/java/com/parsely/parselyandroid/ParselyVideoMetadata.kt @@ -1,5 +1,7 @@ package com.parsely.parselyandroid +import java.util.Calendar + /** * ParselyMetadata for video content. */ @@ -13,7 +15,7 @@ class ParselyVideoMetadata * @param tags User-defined tags for the video. Up to 20 are allowed. * @param thumbUrl URL at which the main image for this video is located. * @param title The title of the video. - * @param publicationDateMilliseconds The timestamp in milliseconds this video was published. + * @param pubDate The timestamp in milliseconds this video was published. * @param durationSeconds Duration of the video in seconds. Required. */( authors: List? = null, @@ -22,9 +24,9 @@ class ParselyVideoMetadata tags: List? = null, thumbUrl: String? = null, title: String? = null, - publicationDateMilliseconds: Long? = null, + pubDate: Calendar? = null, @JvmField internal val durationSeconds: Int -) : ParselyMetadata(authors, videoId, section, tags, thumbUrl, title, publicationDateMilliseconds) { +) : ParselyMetadata(authors, videoId, section, tags, thumbUrl, title, pubDate) { /** * Turn this object into a Map * diff --git a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt index 9cc989b5..8f57335b 100644 --- a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt +++ b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt @@ -4,8 +4,6 @@ import org.assertj.core.api.Assertions.assertThat import org.assertj.core.api.MapAssert import org.junit.Before import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner internal class EventsBuilderTest { private lateinit var sut: EventsBuilder @@ -161,7 +159,7 @@ internal class EventsBuilderTest { fun `given metadata is not null, when creating a pixel, include metadata`() { // given val metadata = ParselyMetadata( - ArrayList(), "link", "section", null, null, null, 0 + ArrayList(), "link", "section", null, null, null, null ) // when diff --git a/parsely/src/test/java/com/parsely/parselyandroid/ParselyMetadataTest.kt b/parsely/src/test/java/com/parsely/parselyandroid/ParselyMetadataTest.kt index 290d7c59..3bf8b61e 100644 --- a/parsely/src/test/java/com/parsely/parselyandroid/ParselyMetadataTest.kt +++ b/parsely/src/test/java/com/parsely/parselyandroid/ParselyMetadataTest.kt @@ -17,7 +17,7 @@ class ParselyMetadataTest { tags, thumbUrl, title, - publicationDate.inWholeMilliseconds + pubDate ) // when @@ -38,7 +38,7 @@ class ParselyMetadataTest { tags, thumbUrl, title, - publicationDate.inWholeMilliseconds, + pubDate, duration ) @@ -56,7 +56,7 @@ class ParselyMetadataTest { val tags = arrayListOf("first tag", "second tag") val thumbUrl = "sample thumb url" val title = "sample title" - val publicationDate = 100.seconds + val pubDate = Calendar.getInstance().apply { set(2023, 0, 1) } val expectedParselyMetadataMap = mapOf( "authors" to authors, @@ -65,7 +65,7 @@ class ParselyMetadataTest { "tags" to tags, "thumb_url" to thumbUrl, "title" to title, - "pub_date_tmsp" to publicationDate.inWholeSeconds + "pub_date_tmsp" to pubDate.timeInMillis / 1000 ) } }