From f28b2f0c3647cb54f24fa4d23cbf9d5f646779e2 Mon Sep 17 00:00:00 2001
From: Wojtek Zieba <wojtek.zieba@automattic.com>
Date: Fri, 20 Oct 2023 11:16:05 +0200
Subject: [PATCH 1/3] style: remove unnecessary secure id assignment

---
 .../java/com/parsely/parselyandroid/EventsBuilderTest.kt     | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
index 33cfe618..9a0cce4d 100644
--- a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
+++ b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
@@ -22,11 +22,6 @@ internal class EventsBuilderTest {
             applicationContext,
             TEST_SITE_ID,
         )
-        Settings.Secure.putString(
-            applicationContext.contentResolver,
-            Settings.Secure.ANDROID_ID,
-            "android_id"
-        )
     }
 
     @Test

From abf2cc0644bfb36704ba3a218871d90911b2c416 Mon Sep 17 00:00:00 2001
From: Wojtek Zieba <wojtek.zieba@automattic.com>
Date: Fri, 20 Oct 2023 11:26:13 +0200
Subject: [PATCH 2/3] style: minor code-style improvements

---
 .../java/com/parsely/parselyandroid/EventsBuilderTest.kt | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
index 9a0cce4d..54831982 100644
--- a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
+++ b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
@@ -11,8 +11,7 @@ import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
 
 @RunWith(RobolectricTestRunner::class)
-internal class EventsBuilderTest {
-
+class EventsBuilderTest {
     private lateinit var sut: EventsBuilder
 
     @Before
@@ -166,8 +165,9 @@ internal class EventsBuilderTest {
     @Test
     fun `given metadata is not null, when creating a pixel, include metadata`() {
         // given
-        val metadata =
-            ParselyMetadata(ArrayList<String>(), "link", "section", null, null, null, null)
+        val metadata = ParselyMetadata(
+            ArrayList<String>(), "link", "section", null, null, null, null
+        )
 
         // when
         val event: Map<String, Any> = sut.buildEvent(
@@ -202,7 +202,6 @@ internal class EventsBuilderTest {
                     .containsEntry("parsely_site_uuid", null)
             }
 
-
     companion object {
         const val TEST_SITE_ID = "Example"
         const val TEST_URL = "http://example.com/some-old/article.html"

From 53942121681df51bc750c6afc1a5b0ca11b00a15 Mon Sep 17 00:00:00 2001
From: Wojtek Zieba <wojtek.zieba@automattic.com>
Date: Fri, 20 Oct 2023 11:54:33 +0200
Subject: [PATCH 3/3] tests: update test names to match when-then schema

---
 .../java/com/parsely/parselyandroid/EventsBuilderTest.kt  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
index 54831982..5630a8d5 100644
--- a/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
+++ b/parsely/src/test/java/com/parsely/parselyandroid/EventsBuilderTest.kt
@@ -24,7 +24,7 @@ class EventsBuilderTest {
     }
 
     @Test
-    fun `events builder prepares correct pageview pixel`() {
+    fun `when building pageview event, then build the correct one`() {
         // when
         val event: Map<String, Any> = sut.buildEvent(
             TEST_URL,
@@ -43,7 +43,7 @@ class EventsBuilderTest {
     }
 
     @Test
-    fun `events builder prepares correct heartbeat pixel`() {
+    fun `when building heartbeat event, then build the correct one`() {
         // when
         val event: Map<String, Any> = sut.buildEvent(
             TEST_URL,
@@ -62,7 +62,7 @@ class EventsBuilderTest {
     }
 
     @Test
-    fun `events builder prepares correct videostart pixel`() {
+    fun `when building videostart event, then build the correct one`() {
         // when
         val event: Map<String, Any> = sut.buildEvent(
             TEST_URL,
@@ -81,7 +81,7 @@ class EventsBuilderTest {
     }
 
     @Test
-    fun `events builder prepares correct vheartbeat pixel`() {
+    fun `when building vheartbeat event, then build the correct one`() {
         // when
         val event: Map<String, Any> = sut.buildEvent(
             TEST_URL,