Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Implement ListOffsetRequestV1 #841

Merged
merged 12 commits into from
Jul 24, 2018
Merged

Conversation

emmettbutler
Copy link
Contributor

This pull request fixes #832 by adding support for the v1 ListOffsetRequest. It also changes the name of OffsetRequest to ListOffsetRequest to remain consistent with modern documentation.

@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #841 into master will decrease coverage by 3.09%.
The diff coverage is 98.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #841     +/-   ##
=========================================
- Coverage   83.73%   80.63%   -3.1%     
=========================================
  Files          27       27             
  Lines        3621     3667     +46     
  Branches      547      553      +6     
=========================================
- Hits         3032     2957     -75     
- Misses        443      565    +122     
+ Partials      146      145      -1
Impacted Files Coverage Δ
pykafka/balancedconsumer.py 89.47% <ø> (+0.87%) ⬆️
pykafka/simpleconsumer.py 83.22% <0%> (-2.69%) ⬇️
pykafka/protocol.py 94.07% <100%> (+0.16%) ⬆️
pykafka/broker.py 84.39% <100%> (-6.26%) ⬇️
pykafka/rdkafka/helpers.py 20% <0%> (-73.34%) ⬇️
pykafka/managedbalancedconsumer.py 45.03% <0%> (-32.46%) ⬇️
pykafka/connection.py 69.3% <0%> (-16.84%) ⬇️
pykafka/cluster.py 68.53% <0%> (-5.62%) ⬇️
pykafka/utils/__init__.py 66.66% <0%> (-5.13%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a898b...79cec43. Read the comment docs.

@emmettbutler emmettbutler merged commit 87385f2 into master Jul 24, 2018
@emmettbutler emmettbutler deleted the enhancement/listoffsetrequestv1 branch July 24, 2018 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OffsetRequest v1
2 participants