Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider converting to ASP.NET Core minimal API #4168

Open
mauroservienti opened this issue May 15, 2024 · 1 comment
Open

Consider converting to ASP.NET Core minimal API #4168

mauroservienti opened this issue May 15, 2024 · 1 comment

Comments

@mauroservienti
Copy link
Member

ServiceControl uses regular ASP.NET controllers. It would be desirable to move to minimal API for the following reasons:

  • minimal API is AOT friendly; it would be a step towards enabling AOT in ServiceControl
  • minimal API doesn't require assembly scanning to locate controllers, which simplifies acceptance tests

When facing the task, it's important to keep in mind the impact of moving from well-scoped controllers to something with no easy way to cluster related HTTP request handlers together. For example, one option is to define sort of "modules," and then use extension methods to configure HTTP endpoints.

@awright18
Copy link
Contributor

Seems like route groups might help. It sounds like you want the best of both worlds (controllers and minimal APIs), make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants