Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: 'NServiceBus sagas: Timeouts' #6895

Open
BenHughesTPR opened this issue Nov 5, 2024 · 1 comment · May be fixed by #6898
Open

Feedback: 'NServiceBus sagas: Timeouts' #6895

BenHughesTPR opened this issue Nov 5, 2024 · 1 comment · May be fixed by #6898
Assignees

Comments

@BenHughesTPR
Copy link

Feedback for 'NServiceBus sagas: Timeouts' https://docs.particular.net/tutorials/nservicebus-sagas/2-timeouts/

Location in GitHub: https://github.com/Particular/docs.particular.net/blob/master/tutorials/nservicebus-sagas/2-timeouts/tutorial.md

Inconsistency: previous step of tutorial (https://docs.particular.net/tutorials/nservicebus-sagas/1-saga-basics/#exercise-saga-state) suggests naming of Saga / SagaData as:

  • ShippingPolicy
  • ShippingPolicyData

But this step suggests:

  • BuyersRemorsePolicy
  • BuyersRemorseState

Is there a preferred convention between these?

@andreasohlund
Copy link
Member

I've updated #6898 to include aligning all naming to use "Data" as the suffix since the property on the actual saga is .Data

@andreasohlund andreasohlund self-assigned this Nov 6, 2024
@andreasohlund andreasohlund linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants