Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugepages.sh script doesn't handle start[ed]/begin hooks #12

Open
Hamled opened this issue Jan 31, 2021 · 3 comments
Open

hugepages.sh script doesn't handle start[ed]/begin hooks #12

Hamled opened this issue Jan 31, 2021 · 3 comments

Comments

@Hamled
Copy link

Hamled commented Jan 31, 2021

After upgrading to libvirt 7.0.0 (at least, the version published to Arch's community package repo on 1/20/2021) I started getting errors from the hugepages.sh script. It was trying to call functions for the start/begin and started/begin events.

I'm not sure what has changed as the libvirt docs mention those qemu events being in place for years now, and I never received these errors before.

Creating some empty functions with the appropriate names seems to be working on my machine.

@Hamled
Copy link
Author

Hamled commented Jan 31, 2021

It turns out this was happening because I had placed the hugepages.sh script directly in the qemu.d directory and had symlinked to it from the usual vm_name/hook_name/state_name directory.

Apparently starting with 6.5.0 any script files in the qemu.d directory will be executed by default. Closing as this is not really a VFIO-Tools issue.

@Hamled Hamled closed this as completed Jan 31, 2021
@SharkWipf
Copy link
Member

It is, actually. The qemu.d folder did not exist at the time this hook helper was created, and apparently libvirt 6.5 implements its own qemu.d folder, which is handled exactly as you say: all scripts in it are directly executed.
While it does not directly conflict with the hook helper, as the libvirt implementation does not execute files in subfolders, it might be worth changing the name of our folder, or at least document how it now overlaps with Libvirt's own implementation.
I'm not gonna have time to change this right away, so if you don't mind, I'm reopening this issue until I (or @ShoelaceMan maybe) get around to fixing it.

@SharkWipf SharkWipf reopened this Jan 31, 2021
@daiaji
Copy link

daiaji commented Jul 28, 2022

Excuse me, is the script manager available now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants