Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify github workflows #128

Open
ma595 opened this issue Dec 2, 2023 · 0 comments
Open

Simplify github workflows #128

ma595 opened this issue Dec 2, 2023 · 0 comments
Assignees
Labels

Comments

@ma595
Copy link
Collaborator

ma595 commented Dec 2, 2023

There are currently three separate workflows doing similar things. Some simplification is needed.

  • python-ci
    This builds all detectree2 dependencies and runs pytest from the root directory, executing a different set of tests.

  • docker-test
    This builds on top of a docker container with detectree2 installed in order to speed up execution (the detectron wheel is not built). It only supports CPU execution. A single integration test is executed requiring a dataset to be cloned from a separate repo (not documented) detectree2-data.

  • sphinx-ci
    This builds detectree2 again for the documentation.

Current issues:

  • Redundancy in build - two workflows doing identical things docker-test and python-ci.
  • both workflows do style, static type checking, import checks.

python-ci:

  • GDAL version is explicitly set despite existing in setup.py.
  • Unnecessary pip installs.

docker-test:

  • --continue-on-error flag is set in flake8 and integration test.

See #38 for more on workflow dependencies.

@ma595 ma595 added the build label Dec 2, 2023
@ma595 ma595 self-assigned this Dec 2, 2023
@ma595 ma595 mentioned this issue Dec 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant