Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Remapping MC Jars throws ArrayOutOfBoundsException #97

Open
ghost opened this issue Mar 11, 2021 · 4 comments
Open

Remapping MC Jars throws ArrayOutOfBoundsException #97

ghost opened this issue Mar 11, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 11, 2021

The error Message. I looked at the code and noticed at
net.patchworkmc.patcher.mapping.Tsrg.readMappings(Tsrg.java:43) (the exact error line)
there is a assumption of a length 2 or more. if this is needed, then I would recommend having a try catch to throw a more descriptive error.

@MisterSilvereagle
Copy link

Got the same error.

If the developers need a output, here it is:

[main/INFO] (PatchworkUI) Welcome to Patchwork Patcher! [main/INFO] (PatchworkUI) Patchwork is still an early project, things might not work as expected! Let us know the issues on GitHub! [pool-2-thread-1/WARN] (Patchwork) Merged minecraft jar not found, generating one! [pool-2-thread-1/INFO] (ResourceDownloader) Downloading Minecraft jars [pool-2-thread-1/INFO] (ResourceDownloader) Merging and remapping Minecraft jars [pool-2-thread-1/ERROR] (Patchwork) Couldn't setup Patchwork! java.lang.ArrayIndexOutOfBoundsException: 1 at net.patchworkmc.patcher.mapping.Tsrg.readMappings(Tsrg.java:43) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at net.patchworkmc.patcher.util.ResourceDownloader.setupAndLoadMappings(ResourceDownloader.java:99) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at net.patchworkmc.patcher.util.ResourceDownloader.createAndRemapMinecraftJar(ResourceDownloader.java:75) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at net.patchworkmc.patcher.Patchwork.createInner(Patchwork.java:414) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at net.patchworkmc.patcher.Patchwork.create(Patchwork.java:372) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at net.patchworkmc.patcher.ui.PatchworkUI.startPatching(PatchworkUI.java:300) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at net.patchworkmc.patcher.ui.PatchworkUI.lambda$null$9(PatchworkUI.java:265) ~[patchwork-patcher-0.5-SNAPSHOT-ui.jar:0.5-SNAPSHOT] at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_281] at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_281] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source) [?:1.8.0_281] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) [?:1.8.0_281] at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_281] at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_281] at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]

Hope you can help, this is an awesome project!

@chxlky
Copy link

chxlky commented Mar 14, 2021

Can confirm, has happened to me too. Although perhaps a temporary solution would be to use patcher v0.3. (1.16.4 mods are internally compatible with 1.16.5, so it should work, i think) This happened to me on v0.4, now that I've seen you're using a pre-release snapshot of v0.5.

@cittyinthecloud
Copy link
Contributor

SRG changed their format and the mapping downloader for 1.16.5 is broke, not sure if we wanna hard code an older URL or what

@shedaniel
Copy link
Contributor

You gonna make this download from the mcp config maven, because that wasn’t changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants