Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Day-Night Theme #19

Open
beinganonymous opened this issue Aug 6, 2019 · 3 comments
Open

Add Day-Night Theme #19

beinganonymous opened this issue Aug 6, 2019 · 3 comments
Labels
enhancement New feature or request feature
Milestone

Comments

@beinganonymous
Copy link
Contributor

Add Day-Night Theme which can be adjusted by button click and TimeZone

@PatilShreyas
Copy link
Owner

Hi @beinganonymous.
We have implemented Material Design library in our app. Stable DayNight theme is currently available in AppCompat support library. In Material Design library, this theme is available but not in stable release, it's available in beta version. What you think? What will have to do? Should we use beta library?

@beinganonymous
Copy link
Contributor Author

Hi @PatilShreyas.
I think we should try out beta version of DayNight theme and lets see how it goes.
Or we can design 2 base application theme,

  1. Theme.MaterialComponents.Light
  2. Theme.MaterialComponents.Dark

and we can change these themes using buttons and according to scenario.
What do you say ?

@PatilShreyas
Copy link
Owner

Yes right. Then we will give try to beta version first. If it works well then fine otherwise your suggestion will be helpful. Thanks 😃

@PatilShreyas PatilShreyas added this to the v1.0 milestone Aug 9, 2019
@PatilShreyas PatilShreyas added enhancement New feature or request feature labels Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

No branches or pull requests

2 participants