Skip to content

Commit 5a3a219

Browse files
committed
maint: Remove core/remove and core/url.
Remove core/remove and core/url and it's usage in pat-slides. core/url wasn't used at all and core/remove did invoke the event to invoke clean-up routines. But core/remove did that by patching the internal cleanData jQuery API. This resulted in an infinite recursion error in combination with pat-tiptap from Mockup. pat-slides is currently not in a working state, so the removal is OK. Anyways, this triggers the question how to handle Pattern cleanup in the future. The answer is in a mutation observer on document level, but this will be part of a future release.
1 parent 7dd4c36 commit 5a3a219

File tree

4 files changed

+0
-147
lines changed

4 files changed

+0
-147
lines changed

src/core/remove.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/core/url.js

Lines changed: 0 additions & 63 deletions
This file was deleted.

src/core/url.test.js

Lines changed: 0 additions & 68 deletions
This file was deleted.

src/pat/slides/slides.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
import $ from "jquery";
77
import registry from "../../core/registry";
88
import utils from "../../core/utils";
9-
import url from "../../core/url";
10-
import "../../core/remove";
119

1210
var slides = {
1311
name: "slides",

0 commit comments

Comments
 (0)